Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: tools/gn/ninja_binary_target_writer.h

Issue 1210143003: GN: Throw an error for duplicate object files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_ 5 #ifndef TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_
6 #define TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_ 6 #define TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "tools/gn/config_values.h" 9 #include "tools/gn/config_values.h"
10 #include "tools/gn/ninja_target_writer.h" 10 #include "tools/gn/ninja_target_writer.h"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // 109 //
110 // The order-only dependencies are the non-linkable deps passed in as an 110 // The order-only dependencies are the non-linkable deps passed in as an
111 // argument, plus the data file depdencies in the target. 111 // argument, plus the data file depdencies in the target.
112 void WriteOrderOnlyDependencies( 112 void WriteOrderOnlyDependencies(
113 const UniqueVector<const Target*>& non_linkable_deps); 113 const UniqueVector<const Target*>& non_linkable_deps);
114 114
115 // Returns the computed name of the Windows .pch file for the given 115 // Returns the computed name of the Windows .pch file for the given
116 // tool type. The tool must support precompiled headers. 116 // tool type. The tool must support precompiled headers.
117 OutputFile GetWindowsPCHFile(Toolchain::ToolType tool_type) const; 117 OutputFile GetWindowsPCHFile(Toolchain::ToolType tool_type) const;
118 118
119 // Checks for duplicates in the given list of output files. If any duplicates
120 // are found, throws an error and return false.
121 bool CheckForDuplicateObjectFiles(const std::vector<OutputFile>& files) const;
122
119 const Tool* tool_; 123 const Tool* tool_;
120 124
121 // Cached version of the prefix used for rule types for this toolchain. 125 // Cached version of the prefix used for rule types for this toolchain.
122 std::string rule_prefix_; 126 std::string rule_prefix_;
123 127
124 DISALLOW_COPY_AND_ASSIGN(NinjaBinaryTargetWriter); 128 DISALLOW_COPY_AND_ASSIGN(NinjaBinaryTargetWriter);
125 }; 129 };
126 130
127 #endif // TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_ 131 #endif // TOOLS_GN_NINJA_BINARY_TARGET_WRITER_H_
128 132
OLDNEW
« no previous file with comments | « no previous file | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698