Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 1210103004: DOM breakpoint is not properly aligned with its checkbox in DOM breakpoints tab (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/components/breakpointsList.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 6ad8ff13cabdd2214861085771da0b81b42f9d89..2fa81015885e7f24ad799a5f03d6e653c4115ac3 100644
--- a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -36,6 +36,7 @@ WebInspector.DOMBreakpointsSidebarPane = function()
{
WebInspector.BreakpointsSidebarPaneBase.call(this, WebInspector.UIString("DOM Breakpoints"));
this._domBreakpointsSetting = WebInspector.settings.createLocalSetting("domBreakpoints", []);
+ this.listElement.classList.add("dom-breakpoints-list");
this._breakpointElements = {};
@@ -228,15 +229,15 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
element._checkboxElement = checkboxLabel.checkboxElement;
element.appendChild(checkboxLabel);
- var labelElement = createElement("span");
+ var labelElement = createElementWithClass("div", "dom-breakpoint");
element.appendChild(labelElement);
var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReference(node);
linkifiedNode.classList.add("monospace");
+ linkifiedNode.style.display = "block";
labelElement.appendChild(linkifiedNode);
var description = createElement("div");
- description.className = "source-text";
description.textContent = this._breakpointTypeLabels[type];
labelElement.appendChild(description);
« no previous file with comments | « no previous file | Source/devtools/front_end/components/breakpointsList.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698