Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1210103002: Revert of "Lazily constructed bespoke cancellable timer task." (Closed)

Created:
4 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 10 months ago
Reviewers:
sof, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of "Lazily constructed bespoke cancellable timer task." Looks like the patch broke http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnotifications%2Fserviceworker-notificationclick-openwindow-crash.html This patch reverts https://codereview.chromium.org/1185643002/ The revert button on the WEB UI didn't work, for soem reason I don't understand the patch failed to apply so I'm doing it manually :/ BUG=498229, 463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197840

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -38 lines) Patch
M Source/platform/Timer.h View 1 5 chunks +13 lines, -28 lines 0 comments Download
M Source/platform/Timer.cpp View 4 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
alex clarke (OOO till 29th)
Looks like I had to revert this manually :(
4 years, 10 months ago (2015-06-25 16:44:12 UTC) #2
eae
On 2015/06/25 16:44:12, alexclarke1 wrote: > Looks like I had to revert this manually :( ...
4 years, 10 months ago (2015-06-25 16:47:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210103002/1
4 years, 10 months ago (2015-06-25 16:48:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/48763) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
4 years, 10 months ago (2015-06-25 16:52:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210103002/20001
4 years, 10 months ago (2015-06-25 17:03:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197840
4 years, 10 months ago (2015-06-25 18:12:48 UTC) #12
sof
4 years, 10 months ago (2015-06-25 18:27:45 UTC) #14
Message was sent while issue was closed.
lgtm.

it didn't apply cleanly due to http://crrev.com/1211883002 , i'm guessing.

Powered by Google App Engine
This is Rietveld 408576698