Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1210073014: Switch Linux and CrOS to BoringSSL. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
Reviewers:
Nico, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch Linux and CrOS to BoringSSL. If this causes problems, please revert first and ask questions later. BUG=462040 Committed: https://crrev.com/df391ba1d19134bb0a6e895a4a33f1af4932545d Cr-Commit-Position: refs/heads/master@{#338713}

Patch Set 1 #

Patch Set 2 : Redo with various upcoming fixes merged #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : typo #

Patch Set 7 : Remove Android redundancy, default to use_openssl on. #

Patch Set 8 : better comment, try jobs on PS7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 3 chunks +5 lines, -6 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (2 generated)
davidben
Okay, I believe this is finally ready. I will not land this until after branch ...
5 years, 5 months ago (2015-07-09 22:42:34 UTC) #2
Nico
android too, right?
5 years, 5 months ago (2015-07-09 22:44:02 UTC) #3
davidben
On 2015/07/09 22:44:02, Nico wrote: > android too, right? Android's been on BoringSSL/OpenSSL since it ...
5 years, 5 months ago (2015-07-09 22:45:28 UTC) #4
davidben
On 2015/07/09 22:45:28, David Benjamin wrote: > On 2015/07/09 22:44:02, Nico wrote: > > android ...
5 years, 5 months ago (2015-07-09 22:50:50 UTC) #5
Nico
LGTM ONLY VALID UNTIL 2015-07-12
5 years, 5 months ago (2015-07-09 22:57:06 UTC) #6
davidben
(cast_shell_linux is red on PS7. I reran them on PS8, but it should still be ...
5 years, 5 months ago (2015-07-10 16:33:19 UTC) #7
davidben
I believe we've now branched? chrome/VERSION says MAJOR=46, so it should be okay to land ...
5 years, 5 months ago (2015-07-13 17:43:48 UTC) #8
Ryan Sleevi
lgtm
5 years, 5 months ago (2015-07-13 17:48:44 UTC) #9
Nico
lgtm
5 years, 5 months ago (2015-07-13 17:55:58 UTC) #10
Nico
(but i haven't received the ""m45 branch is here" mail yet, so maybe wait until ...
5 years, 5 months ago (2015-07-13 17:56:57 UTC) #11
davidben
On 2015/07/13 17:56:57, Nico wrote: > (but i haven't received the ""m45 branch is here" ...
5 years, 5 months ago (2015-07-13 18:13:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210073014/130001
5 years, 5 months ago (2015-07-14 16:13:15 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 5 months ago (2015-07-14 17:57:39 UTC) #15
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/df391ba1d19134bb0a6e895a4a33f1af4932545d Cr-Commit-Position: refs/heads/master@{#338713}
5 years, 5 months ago (2015-07-14 17:58:39 UTC) #16
hongchan
5 years, 5 months ago (2015-07-14 20:01:15 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:130001) has been created in
https://codereview.chromium.org/1235673005/ by hongchan@chromium.org.

The reason for reverting is: This CL seems to cause the issue in Chromium build
system.

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux....

Powered by Google App Engine
This is Rietveld 408576698