tests/PictureTest.cpp - Issue 1210053008: Fix leak in PictureTest.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureTest.cpp

Issue 1210053008: Fix leak in PictureTest.cpp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index b235a0cc23e512ffe0c2122c83be19dc25ba61fd..ae1ef6500257ffe63caa8f31df16b3c711f49ce1 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -993,7 +993,8 @@ static void test_cull_rect_reset(skiatest::Reporter* reporter) {

SkPaint paint;

canvas->drawRect(bounds, paint);

- const SkBigPicture* picture = recorder.endRecordingAsPicture(bounds)->asSkBigPicture();

+ SkAutoTUnref<const SkPicture> p(recorder.endRecordingAsPicture(bounds));

+ const SkBigPicture* picture = p->asSkBigPicture();

REPORTER_ASSERT(reporter, picture);

SkRect finalCullRect = picture->cullRect();

« no previous file with comments | « no previous file | no next file » | no next file with comments »