Remove unused untrusted implementations of NaClSendDatagram() and others

Remove unused untrusted implementations of NaClSendDatagram() and others

In trusted code, NaClSendDatagram() and NaClReceiveDatagram() are part
of the internal layers of IMC, on top of which higher-level NaClDesc
passing is implemented.  It does not make sense to have untrusted
implementations of these, and they are not used anyway.  Their
presence was confusing to someone new to this code (see
https://groups.google.com/d/msg/native-client-discuss/5B5LFptZTyM/fI48VK4PDhUJ).

We can also remove some other unused definitions from this file.

BUG=none
TEST=build

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/b1a5d2159561eaffcc24151d0ac7cf39cf7d37ba

[Mark Seaborn, 2015-07-08 15:28:22]

mseaborn@chromium.org changed reviewers:
+ jvoung@chromium.org

[jvoung (off chromium), 2015-07-08 17:20:10]

https://codereview.chromium.org/1210053007/diff/1/src/shared/imc/nacl/nacl_im...
File src/shared/imc/nacl/nacl_imc.cc (right):

https://codereview.chromium.org/1210053007/diff/1/src/shared/imc/nacl/nacl_im...
src/shared/imc/nacl/nacl_imc.cc:18: int NaClSocketPair(NaClHandle pair[2]) {
It wasn't clear to me the difference in categorization between NaClSocketPair
and NaClSendDatagram. Both seem to be thin wrappers around imc_*() functions.

[Mark Seaborn, 2015-07-08 17:40:13]

https://codereview.chromium.org/1210053007/diff/1/src/shared/imc/nacl/nacl_im...
File src/shared/imc/nacl/nacl_imc.cc (right):

https://codereview.chromium.org/1210053007/diff/1/src/shared/imc/nacl/nacl_im...
src/shared/imc/nacl/nacl_imc.cc:18: int NaClSocketPair(NaClHandle pair[2]) {
On 2015/07/08 17:20:10, jvoung wrote:
> It wasn't clear to me the difference in categorization between NaClSocketPair
> and NaClSendDatagram. Both seem to be thin wrappers around imc_*() functions.

The difference is that there is some test code that calls NaClSocketPair(), in
tests/unittests/shared/{srpc,imc}/.

In this change I'm just aiming to reduce the possibility of confusion by
removing dead code.  I'm not attempting to clean up IMC generally, since it's
deprecated (https://code.google.com/p/nativeclient/issues/detail?id=3864) and
the longer term cleanup is just to remove it.

[jvoung (off chromium), 2015-07-08 17:58:40]

lgtm

[Mark Seaborn, 2015-07-08 18:00:56]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-07-08 18:01:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210053007/1

[commit-bot: I haz the power, 2015-07-08 21:58:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/b1a5d2159...