Fix SkTileImageFilter clipping/cropRect interaction issue

Fix SkTileImageFilter clipping/cropRect interaction issue

BUG=499499
Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391

[robertphillips, 2015-06-25 19:09:25]

Patchset #2 (id:20001) has been deleted

[robertphillips, 2015-06-25 19:13:57]

robertphillips@google.com changed reviewers:
+ reed@google.com, senorblanco@google.com

[reed1, 2015-06-25 21:18:55]

lgtm

[Stephen White, 2015-06-25 21:58:14]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-06-25 21:58:15]

LGTM

https://codereview.chromium.org/1210053003/diff/1/src/effects/SkTileImageFilt...
File src/effects/SkTileImageFilter.cpp (right):

https://codereview.chromium.org/1210053003/diff/1/src/effects/SkTileImageFilt...
src/effects/SkTileImageFilter.cpp:43: // For don't apply any clip to the source
(since it is usually very small and all of it will be
Nit: "For" -> "For now" ?

https://codereview.chromium.org/1210053003/diff/1/src/effects/SkTileImageFilt...
src/effects/SkTileImageFilter.cpp:45: SkImageFilter::Context srcCtx(ctx.ctm(),
SkIRect::MakeLargest(), ctx.cache());
Nit: probably don't need the SkImageFilter:: scoping here, unless you really
want it.

[robertphillips, 2015-06-26 12:24:10]

https://codereview.chromium.org/1210053003/diff/1/src/effects/SkTileImageFilt...
File src/effects/SkTileImageFilter.cpp (right):

https://codereview.chromium.org/1210053003/diff/1/src/effects/SkTileImageFilt...
src/effects/SkTileImageFilter.cpp:43: // For don't apply any clip to the source
(since it is usually very small and all of it will be
On 2015/06/25 21:58:15, Stephen White wrote:
> Nit: "For" -> "For now" ?

Done.

https://codereview.chromium.org/1210053003/diff/1/src/effects/SkTileImageFilt...
src/effects/SkTileImageFilter.cpp:45: SkImageFilter::Context srcCtx(ctx.ctm(),
SkIRect::MakeLargest(), ctx.cache());
On 2015/06/25 21:58:15, Stephen White wrote:
> Nit: probably don't need the SkImageFilter:: scoping here, unless you really
> want it.

Done.

[robertphillips, 2015-06-26 12:24:16]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[robertphillips, 2015-06-26 12:24:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/1210053003/#ps30001
(title: "Address code review comments")

[commit-bot: I haz the power, 2015-06-26 12:24:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210053003/30001

[commit-bot: I haz the power, 2015-06-26 12:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-26 12:29:48]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-06-26 15:06:52]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-06-26 15:07:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210053003/30001

[commit-bot: I haz the power, 2015-06-26 15:07:44]

Committed patchset #2 (id:30001) as
https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391

[bsalomon, 2015-07-01 18:02:34]

A revert of this CL (patchset #2 id:30001) has been created in
https://codereview.chromium.org/1219193002/ by bsalomon@google.com.

The reason for reverting is: Perf regression:
https://code.google.com/p/chromium/issues/detail?id=505564.