Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/chrome_select_file_dialog_factory_win.cc

Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-unsequenced
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_select_file_dialog_factory_win.h" 5 #include "chrome/browser/chrome_select_file_dialog_factory_win.h"
6 6
7 #include <Windows.h> 7 #include <Windows.h>
8 #include <commdlg.h> 8 #include <commdlg.h>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 void OnFailure(); 212 void OnFailure();
213 213
214 base::FilePath path_; 214 base::FilePath path_;
215 int one_based_filter_index_; 215 int one_based_filter_index_;
216 base::WaitableEvent event_; 216 base::WaitableEvent event_;
217 217
218 DISALLOW_COPY_AND_ASSIGN(GetSaveFileNameClient); 218 DISALLOW_COPY_AND_ASSIGN(GetSaveFileNameClient);
219 }; 219 };
220 220
221 GetSaveFileNameClient::GetSaveFileNameClient() 221 GetSaveFileNameClient::GetSaveFileNameClient()
222 : event_(true, false), one_based_filter_index_(0) { 222 : one_based_filter_index_(0), event_(true, false) {
223 } 223 }
224 224
225 void GetSaveFileNameClient::WaitForCompletion() { 225 void GetSaveFileNameClient::WaitForCompletion() {
226 event_.Wait(); 226 event_.Wait();
227 } 227 }
228 228
229 void GetSaveFileNameClient::OnProcessCrashed(int exit_code) { 229 void GetSaveFileNameClient::OnProcessCrashed(int exit_code) {
230 event_.Signal(); 230 event_.Signal();
231 } 231 }
232 232
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 335
336 ui::SelectFileDialog* ChromeSelectFileDialogFactory::Create( 336 ui::SelectFileDialog* ChromeSelectFileDialogFactory::Create(
337 ui::SelectFileDialog::Listener* listener, 337 ui::SelectFileDialog::Listener* listener,
338 ui::SelectFilePolicy* policy) { 338 ui::SelectFilePolicy* policy) {
339 return ui::CreateWinSelectFileDialog( 339 return ui::CreateWinSelectFileDialog(
340 listener, 340 listener,
341 policy, 341 policy,
342 base::Bind(GetOpenFileNameImpl, blocking_task_runner_), 342 base::Bind(GetOpenFileNameImpl, blocking_task_runner_),
343 base::Bind(GetSaveFileNameImpl, blocking_task_runner_)); 343 base::Bind(GetSaveFileNameImpl, blocking_task_runner_));
344 } 344 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698