Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1210003003: Better error message for eval=>42 in strict mode (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Better error message for eval=>42 in strict mode BUG=v8:4213 R=arv@chromium.org LOG=N Committed: https://crrev.com/87fd436670ccc4a327b2d4f973b00a3bf3f00161 Cr-Commit-Position: refs/heads/master@{#29299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/preparser.h View 4 chunks +13 lines, -6 lines 0 comments Download
M test/message/arrow-strict-eval-bare-parameter.out View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wingo
5 years, 6 months ago (2015-06-25 13:38:09 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-25 14:51:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210003003/1
5 years, 6 months ago (2015-06-25 15:50:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 16:17:12 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 16:17:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87fd436670ccc4a327b2d4f973b00a3bf3f00161
Cr-Commit-Position: refs/heads/master@{#29299}

Powered by Google App Engine
This is Rietveld 408576698