Chromium Code Reviews| Index: tools/perf/perf_tools/image_decoding_benchmark.py |
| diff --git a/tools/perf/perf_tools/image_decoding_benchmark.py b/tools/perf/perf_tools/image_decoding_benchmark.py |
| index c14a84cbd368b56049ad7fe4b41f1da588ca2282..b3287dfd14032afedb39d17f3d425472cc19771a 100644 |
| --- a/tools/perf/perf_tools/image_decoding_benchmark.py |
| +++ b/tools/perf/perf_tools/image_decoding_benchmark.py |
| @@ -10,25 +10,31 @@ class ImageDecoding(multi_page_benchmark.MultiPageBenchmark): |
| tab.StartTimelineRecording() |
|
tonyg
2013/01/31 23:20:07
Should probably comment out this whole method too.
qinmin
2013/01/31 23:50:55
Done.
|
| def MeasurePage(self, page, tab, results): |
| - tab.StopTimelineRecording() |
| - def _IsDone(): |
| - return tab.EvaluateJavaScript('isDone') |
| + # TODO(qinmin): This android only test may fail after we switch to |
| + # deferred image decoding and impl-side painting. Before we fix the test, |
| + # temporarily disable calculation for lazily decoded images. |
| + # Uncommented the following lines after we fix the timeline for lazily |
| + # decoded images. |
| + return |
| + # tab.StopTimelineRecording() |
| + # def _IsDone(): |
| + # return tab.EvaluateJavaScript('isDone') |
| - decode_image_events = \ |
| - tab.timeline_model.GetAllOfName('DecodeImage') |
| + # decode_image_events = \ |
| + # tab.timeline_model.GetAllOfName('DecodeImage') |
| # If it is a real image benchmark, then store only the last-minIterations |
| # decode tasks. |
| - if (hasattr(page, |
| - 'image_decoding_benchmark_limit_results_to_min_iterations') and |
| - page.image_decoding_benchmark_limit_results_to_min_iterations): |
| - assert _IsDone() |
| - min_iterations = tab.EvaluateJavaScript('minIterations') |
| - decode_image_events = decode_image_events[-min_iterations:] |
| + # if (hasattr(page, |
| + # 'image_decoding_benchmark_limit_results_to_min_iterations') and |
| + # page.image_decoding_benchmark_limit_results_to_min_iterations): |
| + # assert _IsDone() |
| + # min_iterations = tab.EvaluateJavaScript('minIterations') |
| + # decode_image_events = decode_image_events[-min_iterations:] |
| - durations = [d.duration_ms for d in decode_image_events] |
| - if not durations: |
| - results.Add('ImageDecoding_avg', 'ms', 'unsupported') |
| - return |
| - image_decoding_avg = sum(durations) / len(durations) |
| - results.Add('ImageDecoding_avg', 'ms', image_decoding_avg) |
| + # durations = [d.duration_ms for d in decode_image_events] |
| + # if not durations: |
| + # results.Add('ImageDecoding_avg', 'ms', 'unsupported') |
| + # return |
| + # image_decoding_avg = sum(durations) / len(durations) |
| + # results.Add('ImageDecoding_avg', 'ms', image_decoding_avg) |