Issue 1209983002: Only try to delete dictionary elements if the length is actually reduced

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1209983002: Only try to delete dictionary elements if the length is actually reduced (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Only try to delete dictionary elements if the length is actually reduced BUG=v8:4137 LOG=n Committed: https://crrev.com/3f336d41444b597788fd4dd4c0a9231e7c494004 Cr-Commit-Position: refs/heads/master@{#29297}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -30 lines)			Patch
	M	src/elements.cc	View		1 chunk	+32 lines, -30 lines	0 comments	Download

Total messages: 7 (2 generated)

Igor Sheludko

lgtm, but please say in the CL description that it's about dictionary elements.

5 years, 6 months ago (2015-06-25 14:15:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209983002/1

5 years, 6 months ago (2015-06-25 14:16:22 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-25 14:46:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3f336d41444b597788fd4dd4c0a9231e7c494004
Cr-Commit-Position: refs/heads/master@{#29297}