Rename avatarURL to iconURL in the credential manager in Blink.

Rename avatarURL to iconURL in the credential manager in Blink.

As specified in https://w3c.github.io/webappsec/specs/credentialmanagement/#credential

Also change all references to avatar to icon for consistency.

WebCredential::avatarURL() is redirected to WebCredential::iconURL(), but stays until the corresponding change on callsites in Chromium.

This CL is a part of the three-sided patchset:
1. https://codereview.chromium.org/1209953002/ <-- this patch
2. https://codereview.chromium.org/1209363003/
3. https://codereview.chromium.org/1208193003/

BUG=494880, 505445
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197902

[msramek, 2015-06-25 12:47:38]

Patchset #1 (id:1) has been deleted

[msramek, 2015-06-25 13:23:56]

Patchset #1 (id:20001) has been deleted

[msramek, 2015-06-25 13:30:20]

msramek@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[msramek, 2015-06-25 13:30:21]

Hi Mike and Jochen,

I'm starting another trio of renaming CLs. PTAL :)

Since avatarURL is a simple getter, we're not sending any callbacks back to
Chromium, and we're not renaming any files, this should be basically grep and
replace; with the exception of preserving the old method in WebCredential.h.

Thanks,
Martin

[Mike West, 2015-06-25 14:48:42]

LGTM. If you're going to land this before you have the other two patches done,
please create a new bug to tie the three patches together.

Thanks!

https://codereview.chromium.org/1209953002/diff/40001/public/platform/WebCred...
File public/platform/WebCredential.h (right):

https://codereview.chromium.org/1209953002/diff/40001/public/platform/WebCred...
public/platform/WebCredential.h:34: // TODO(mkwst, msramek): Drop this once
Chromium is updated. https://crbug.com/494880
I think you can just leave this with my name in it. The point isn't to list
everyone responsible, but to list someone who knows what the TODO means.

[msramek, 2015-06-26 09:45:05]

Thanks!

Creating a separate bug sounds messy if you've been putting everything into one
master bug so far. I'll just cross-link the three patches like you did before.

https://codereview.chromium.org/1209953002/diff/40001/public/platform/WebCred...
File public/platform/WebCredential.h (right):

https://codereview.chromium.org/1209953002/diff/40001/public/platform/WebCred...
public/platform/WebCredential.h:34: // TODO(mkwst, msramek): Drop this once
Chromium is updated. https://crbug.com/494880
On 2015/06/25 14:48:42, Mike West wrote:
> I think you can just leave this with my name in it. The point isn't to list
> everyone responsible, but to list someone who knows what the TODO means.

Well, let me just remove it in the third corresponding patch, together with the
line below.

[msramek, 2015-06-26 10:32:58]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-06-26 10:33:00]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2015-06-26 10:33:06]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-06-26 10:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209953002/40001

[commit-bot: I haz the power, 2015-06-26 10:37:01]

Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197902