LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js - Issue 1209933003: ServiceWorkerClients::openWindow() should reject with TypeError for an invalid URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

Issue 1209933003: ServiceWorkerClients::openWindow() should reject with TypeError for an invalid URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html ('k') | Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

diff --git a/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js b/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

index 602e044e8644a17447466168c38482cafc55e6ae..31dcf7ba15501ae1dd8b6b233344d99a7d2e30ba 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

+++ b/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

@@ -61,6 +61,15 @@ var TESTS = [

});

+ function testOpenInvalidURL() {

+ synthesizeNotificationClick().then(function(e) {

+ clients.openWindow('http://[test].com').catch(function(error) {

+ self.postMessage('openWindow() can not open invalid url');

nhiroki 2015/07/01 07:00:29 nit: "invalid" -> "an invalid"

Paritosh Kumar 2015/07/01 07:43:19 Thanks. Done.

+ self.postMessage('openWindow() error is: ' + error.name);

+ }).then(runNextTestOrQuit);

+ });

+ },

function testOpenViewSource() {

synthesizeNotificationClick().then(function(e) {

clients.openWindow('view-source://http://test.com').catch(function(c) {