ash/host/ash_remote_window_tree_host_win.cc - Issue 1209913002: InputMethod should stop TextInputClient::InsertChar/InsertText calls when the event is stopped prop…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/host/ash_remote_window_tree_host_win.cc

Issue 1209913002: InputMethod should stop TextInputClient::InsertChar/InsertText calls when the event is stopped prop… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed test failures. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/host/ash_remote_window_tree_host_win.cc

diff --git a/ash/host/ash_remote_window_tree_host_win.cc b/ash/host/ash_remote_window_tree_host_win.cc

index 7ce8718646c1da5d228394436221ee80c2a60e1c..5f109d97e06057ead42eb995430c6780c2018059 100644

--- a/ash/host/ash_remote_window_tree_host_win.cc

+++ b/ash/host/ash_remote_window_tree_host_win.cc

@@ -63,7 +63,7 @@ bool AshRemoteWindowTreeHostWin::DispatchKeyEventPostIME(

input_method_handler()->SetPostIME(true);

ui::EventSource::DeliverEventToProcessor(&event_copy);

input_method_handler()->SetPostIME(false);

- return event_copy.handled();

+ return event_copy.stopped_propagation();

}

ui::EventDispatchDetails AshRemoteWindowTreeHostWin::DeliverEventToProcessor(

« no previous file with comments | « no previous file | ash/host/ash_window_tree_host_ozone.cc » ('j') | ash/ime/input_method_event_handler.cc » ('J')