Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1209903003: VectorICs: Lithium support for vector-based stores. (Closed)

Created:
5 years, 5 months ago by mvstanton
Modified:
5 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: Lithium support for vector-based stores. BUG= Committed: https://crrev.com/8a3cf4ecef1fce76137270845604292bdbdadcd4 Cr-Commit-Position: refs/heads/master@{#29310}

Patch Set 1 #

Patch Set 2 : Ports. #

Total comments: 2

Patch Set 3 : Fix and REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -122 lines) Patch
M src/arm/lithium-arm.h View 1 2 chunks +15 lines, -8 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 3 chunks +25 lines, -3 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 chunks +15 lines, -8 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 2 chunks +19 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 3 chunks +25 lines, -3 lines 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 3 chunks +25 lines, -5 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 9 chunks +41 lines, -9 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +25 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +14 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +16 lines, -3 lines 0 comments Download
M src/ic/ic.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 4 chunks +66 lines, -25 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 3 chunks +25 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.h View 1 2 chunks +15 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 3 chunks +25 lines, -3 lines 0 comments Download
M src/mips64/lithium-mips64.h View 1 2 chunks +15 lines, -8 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 3 chunks +25 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +14 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mvstanton
Hi Yang, Here is the CL we were talking about. Lithium is remarkably boilerplatey. Thanks ...
5 years, 5 months ago (2015-06-25 09:34:04 UTC) #2
Yang
lgtm if comment addressed. https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc#newcode5501 src/arm64/lithium-codegen-arm64.cc:5501: Handle<Code> ic = CodeFactory::StoreICInOptimizedCode( This ...
5 years, 5 months ago (2015-06-26 06:54:41 UTC) #3
mvstanton
Thanks for the review :) --Michael https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/1209903003/diff/20001/src/arm64/lithium-codegen-arm64.cc#newcode5501 src/arm64/lithium-codegen-arm64.cc:5501: Handle<Code> ic = ...
5 years, 5 months ago (2015-06-26 07:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209903003/40001
5 years, 5 months ago (2015-06-26 07:31:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-06-26 07:53:29 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 07:53:50 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8a3cf4ecef1fce76137270845604292bdbdadcd4
Cr-Commit-Position: refs/heads/master@{#29310}

Powered by Google App Engine
This is Rietveld 408576698