Issue 12099006: Merge 174913

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12099006: Merge 174913 (Closed)

Created:
7 years, 10 months ago by Sergey Ulanov

Modified:
7 years, 10 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1364/src/

Visibility:
Public.

More Reviews

Description

Merge 174913 > Fix AudioPipeReader to handle EOF properly. > > PulseAudio is started on demand. When PulseAudio is not started read() alaways > returns 0 (i.e. EOF). Normally pulseaudio is started on demand by libpulse so that > it can be restarted after it's stoped or crashed. Previously AudioPipeReader::DoCapture() > didn't handle properly the case when read() returns 0, which would cause it to get into > indefinite loop when pulseaudio is not started. > > BUG=167801 > > Review URL: https://chromiumcodereview.appspot.com/11744009 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179699

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	remoting/host/linux/audio_pipe_reader.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages