Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1209803002: Upgrade WebGLImageConversion to ES3: Part III (Closed)

Created:
5 years, 6 months ago by Zhenyao Mo
Modified:
5 years, 6 months ago
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Upgrade WebGLImageConversion to ES3: Part III Add pack functions for various formats. Also, makes sure the template functions exit early for unsupported converstion. BUG=497352 TEST=webgl conformance tests R=bajones@chromium.org,kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197936

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -96 lines) Patch
M Source/platform/graphics/gpu/WebGLImageConversion.cpp View 1 2 3 4 8 chunks +189 lines, -96 lines 0 comments Download

Depends on Patchset:

Issue 1120953002 Patch 220001

Messages

Total messages: 8 (1 generated)
Zhenyao Mo
Please review.
5 years, 6 months ago (2015-06-24 23:09:27 UTC) #1
bajones
https://codereview.chromium.org/1209803002/diff/1/Source/platform/graphics/gpu/WebGLImageConversion.cpp File Source/platform/graphics/gpu/WebGLImageConversion.cpp (right): https://codereview.chromium.org/1209803002/diff/1/Source/platform/graphics/gpu/WebGLImageConversion.cpp#newcode28 Source/platform/graphics/gpu/WebGLImageConversion.cpp:28: const double maxUInt32Value = 2^32 - 1; Is there ...
5 years, 6 months ago (2015-06-24 23:17:15 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/1209803002/diff/1/Source/platform/graphics/gpu/WebGLImageConversion.cpp File Source/platform/graphics/gpu/WebGLImageConversion.cpp (right): https://codereview.chromium.org/1209803002/diff/1/Source/platform/graphics/gpu/WebGLImageConversion.cpp#newcode28 Source/platform/graphics/gpu/WebGLImageConversion.cpp:28: const double maxUInt32Value = 2^32 - 1; On 2015/06/24 ...
5 years, 6 months ago (2015-06-24 23:20:47 UTC) #3
bajones
On 2015/06/24 23:20:47, Zhenyao Mo wrote: > If you feel the stdint.h def is better, ...
5 years, 6 months ago (2015-06-25 00:03:44 UTC) #4
Ken Russell (switch to Gerrit)
Very nice and careful work. LGTM
5 years, 6 months ago (2015-06-26 16:40:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209803002/80001
5 years, 6 months ago (2015-06-26 16:46:45 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 19:12:35 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197936

Powered by Google App Engine
This is Rietveld 408576698