Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1209763003: Add a 64-bit ARM builder to the CQ. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a 64-bit ARM builder to the CQ. It's possible this rarely breaks, but I do write ARMv8 code frequently enough that it'll help prevent broken trees. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a981e740978aa032eaa0bb24839cd28ceaed3bdb

Patch Set 1 #

Patch Set 2 : -Trybot #

Total comments: 2

Patch Set 3 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M infra/branch-config/cq.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mtklein_C
Is this how we add bots to the CQ now?
5 years, 6 months ago (2015-06-24 21:34:56 UTC) #2
rmistry
https://codereview.chromium.org/1209763003/diff/20001/infra/branch-config/cq.cfg File infra/branch-config/cq.cfg (right): https://codereview.chromium.org/1209763003/diff/20001/infra/branch-config/cq.cfg#newcode39 infra/branch-config/cq.cfg:39: builders { name: "Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot" } nit: sort (move up ...
5 years, 6 months ago (2015-06-24 21:38:32 UTC) #3
mtklein
https://codereview.chromium.org/1209763003/diff/20001/infra/branch-config/cq.cfg File infra/branch-config/cq.cfg (right): https://codereview.chromium.org/1209763003/diff/20001/infra/branch-config/cq.cfg#newcode39 infra/branch-config/cq.cfg:39: builders { name: "Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot" } On 2015/06/24 21:38:32, rmistry ...
5 years, 6 months ago (2015-06-24 21:39:09 UTC) #5
rmistry
LGTM On 2015/06/24 21:34:56, mtklein_C wrote: > Is this how we add bots to the ...
5 years, 6 months ago (2015-06-24 21:39:36 UTC) #6
mtklein
Very cool.
5 years, 6 months ago (2015-06-24 21:40:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209763003/40001
5 years, 6 months ago (2015-06-24 21:40:40 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/a981e740978aa032eaa0bb24839cd28ceaed3bdb
5 years, 6 months ago (2015-06-24 21:52:27 UTC) #10
rmistry
On 2015/06/24 21:52:27, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) as ...
5 years, 6 months ago (2015-06-24 22:52:36 UTC) #11
mtklein
5 years, 6 months ago (2015-06-24 22:53:04 UTC) #12
Message was sent while issue was closed.
On 2015/06/24 22:52:36, rmistry wrote:
> On 2015/06/24 21:52:27, commit-bot: I haz the power wrote:
> > Committed patchset #3 (id:40001) as
> >
https://skia.googlesource.com/skia/+/a981e740978aa032eaa0bb24839cd28ceaed3bdb
> 
> I tested this with https://codereview.chromium.org/1155123006/ and looks like
> the new trybot showed up.

Thanks!  Yep, looks good.

Powered by Google App Engine
This is Rietveld 408576698