tools/json_to_struct/json_to_struct.py - Issue 1209733002: Add the ability to code generated prepopulated static nested structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_to_struct/json_to_struct.py

Issue 1209733002: Add the ability to code generated prepopulated static nested structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/json_to_struct/element_generator.py ('K') | « tools/json_to_struct/element_generator_test.py ('k') | tools/json_to_struct/struct_generator.py » ('j') | tools/json_to_struct/struct_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/json_to_struct/json_to_struct.py

diff --git a/tools/json_to_struct/json_to_struct.py b/tools/json_to_struct/json_to_struct.py

index 2e9c83c726fb23a28a232cfd24312efdac4b841f..831c739498d0f62f85467b02a272cb00f64aa905 100755

--- a/tools/json_to_struct/json_to_struct.py

+++ b/tools/json_to_struct/json_to_struct.py

@@ -119,7 +119,7 @@ def _GenerateH(basepath, fileroot, head, namespace, schema, description):

schema['type_name'], schema['schema']))

f.write('\n')

- for var_name, value in description.get('int_variables', []).items():

+ for var_name, value in description.get('int_variables', {}).items():

f.write('extern const int %s;\n' % var_name)

f.write('\n')