Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 120973002: Fix inconsistency. (Closed)

Created:
6 years, 12 months ago by Nico
Modified:
6 years, 12 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix inconsistency. On linux, pkg-config.py outputs a 4-tuple. The non-linux fallback path outputs only a 3-tuble, which confuses pkg_config.gni. BUG=none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/linux/pkg-config.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Not sure why this fallback path is here at all though, I'd just remove it ...
6 years, 12 months ago (2013-12-24 18:51:14 UTC) #1
brettw
LGTM. Scottmg and I were hoping to make builds of another platform have some kind ...
6 years, 12 months ago (2013-12-24 21:15:24 UTC) #2
Nico
6 years, 12 months ago (2013-12-24 21:45:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r242456.

Powered by Google App Engine
This is Rietveld 408576698