win10: Fix various ui glitches

chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.h"
 
 #include <dwmapi.h>
 
 #include "base/process/process_handle.h"
+#include "base/win/windows_version.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 #include "chrome/browser/ui/views/frame/browser_frame_common_win.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/browser_window_property_manager_win.h"
 #include "chrome/browser/ui/views/frame/system_menu_insertion_delegate_win.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/browser/ui/views/theme_image_mapper.h"
@@ skipping 316 matching lines @@
       margins.cyTopHeight = kClientEdgeThickness + 1;
     }
     // In maximized mode, we only have a titlebar strip of glass, no side/bottom
     // borders.
     if (!browser_view_->IsFullscreen()) {
       gfx::Rect tabstrip_bounds(
           browser_frame_->GetBoundsForTabStrip(browser_view_->tabstrip()));
       tabstrip_bounds = gfx::win::DIPToScreenRect(tabstrip_bounds);
       margins.cyTopHeight = tabstrip_bounds.bottom() + kDWMFrameTopOffset;
     }
+    if (base::win::GetVersion() >= base::win::VERSION_WIN10) {

[Peter Kasting, 2015/06/25 23:34:12]

Nit: I think this might be clearer if instead of doing this here, you added a
conditional to where we set these nonzero above:

    if (!IsMaximized() && !GetWidget()->IsFullscreen()) {
      margins.cyTopHeight = kClientEdgeThickness + 1;
      // On Windows 10, we don't draw our own window border, so don't extend the
      // nonclient area in for it.
      if (base::win::GetVersion() < base::win::VERSION_WIN10) {
        ...

[scottmg, 2015/06/26 18:29:32]

Done.

+      // No inset on Win10.
+      margins.cxLeftWidth = 0;
+      margins.cxRightWidth = 0;
+      margins.cyBottomHeight = 0;
+    }
   }
   return margins;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserDesktopWindowTreeHost, public:
 
 // static
 BrowserDesktopWindowTreeHost*
     BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost(
         views::internal::NativeWidgetDelegate* native_widget_delegate,
         views::DesktopNativeWidgetAura* desktop_native_widget_aura,
         BrowserView* browser_view,
         BrowserFrame* browser_frame) {
   return new BrowserDesktopWindowTreeHostWin(native_widget_delegate,
                                              desktop_native_widget_aura,
                                              browser_view,
                                              browser_frame);
 }