Remove LayoutFlowThread::maxLogicalHeight().

Remove LayoutFlowThread::maxLogicalHeight().

Use LayoutUnit::max() like everyone else, to avoid errors when approaching
"infinity". We fooled ourselves into thinking that we had two pages (because
column height was clamped to LayoutUnit::max()/2, while the block height was
clamped to LayoutUnit::max()), when we really only had one.

We use saturated arithmetic in LayoutUnit & co anyway, so there's no reason to
be afraid of integer overflow.

BUG=502407
R=dsinclair@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197771

[mstensho (USE GERRIT), 2015-06-24 18:08:28]

Note that the unminimized TC in bug 502407 still crashes. Will file another CL
for that.

[leviw_travelin_and_unemployed, 2015-06-24 18:42:05]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-06-24 18:42:06]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-06-24 18:42:06]

lgtm

https://codereview.chromium.org/1209693002/diff/1/LayoutTests/fast/pagination...
File LayoutTests/fast/pagination/very-tall-auto-height-crash.html (right):

https://codereview.chromium.org/1209693002/diff/1/LayoutTests/fast/pagination...
LayoutTests/fast/pagination/very-tall-auto-height-crash.html:8: <div
style="height:1000px; padding-top:18446744073709551436px;"></div>
Are you sure that's big enough? ;)

[commit-bot: I haz the power, 2015-06-24 18:42:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209693002/1

[mstensho (USE GERRIT), 2015-06-24 18:45:44]

https://codereview.chromium.org/1209693002/diff/1/LayoutTests/fast/pagination...
File LayoutTests/fast/pagination/very-tall-auto-height-crash.html (right):

https://codereview.chromium.org/1209693002/diff/1/LayoutTests/fast/pagination...
LayoutTests/fast/pagination/very-tall-auto-height-crash.html:8: <div
style="height:1000px; padding-top:18446744073709551436px;"></div>
On 2015/06/24 18:42:06, leviw wrote:
> Are you sure that's big enough? ;)

The fuzzer thinks so. :)

[commit-bot: I haz the power, 2015-06-24 19:11:24]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197771