chrome/browser/chrome_elf_init_win.h - Issue 120963002: Use a Finch Experiment to control the Browser Blacklist

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_elf_init_win.h

Issue 120963002: Use a Finch Experiment to control the Browser Blacklist (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Responding to comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

	6 #define CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

	7

	8 // Prepare any initialization code for Chrome Elf's setup (This will generally

	9 // only affect future runs since Chrome Elf is already setup by this point).

	10 void SetupChromeElfInitialization();
	robertshield 2014/01/02 20:42:22 How about InitializeChromeElf()? Having "Initializ How about InitializeChromeElf()? Having "Initialize" and "Setup" in the same name seems redundant. csharp 2014/01/02 21:57:59 I wasn't quite sure since we aren't really initial Show quoted text On 2014/01/02 20:42:22, robertshield wrote: > How about InitializeChromeElf()? Having "Initialize" and "Setup" in the same > name seems redundant. I wasn't quite sure since we aren't really initializing here, but are setting up code for the next initialization. Changed since the old name wasn't really expressing the desired meaning.
	11

	12 // Correctly set the required state for an enabled browser blacklist.
	robertshield 2014/01/02 20:42:22 Drop the word "Correctly" since that is hopefully Drop the word "Correctly" since that is hopefully implicit. csharp 2014/01/02 21:57:59 Done. Show quoted text On 2014/01/02 20:42:22, robertshield wrote: > Drop the word "Correctly" since that is hopefully implicit. Done.
	13 void BrowserBlacklistBeaconSetup();

	14

	15 #endif // CHROME_BROWSER_CHROME_ELF_INIT_WIN_H_

OLD	NEW

« base/win/registry.h ('K') | « chrome/browser/chrome_elf_init_unittest_win.cc ('k') | chrome/browser/chrome_elf_init_win.cc » ('j') | chrome/browser/chrome_elf_init_win.cc » ('J')