[cc] Trace detailed tile info when --trace-all-rendered-frames

cc/picture_layer_tiling.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/picture_layer_tiling.h"
 
 #include "base/debug/trace_event.h"
 #include "cc/math_util.h"
 #include "ui/gfx/point_conversions.h"
 #include "ui/gfx/rect_conversions.h"
 #include "ui/gfx/safe_integer_conversions.h"
 #include "ui/gfx/size_conversions.h"
 
+namespace {
+static bool store_screen_space_quads_on_tiles = false;

[enne (OOO), 2013/02/12 00:21:13]

I agree with Shawn that this isn't great as a static.  Make this a
LayerTreeSetting and just set it as a local member on the tiling itself when you
create it from PictureLayerImpl.

+}
+
 namespace cc {
 
+void PictureLayerTiling::SetStoreScrenSpaceQuadsOnTiles(bool b) {

[enne (OOO), 2013/02/12 00:21:13]

Can you use a better variable name than b?

+  store_screen_space_quads_on_tiles = b;
+}
+
 scoped_ptr<PictureLayerTiling> PictureLayerTiling::Create(
     float contents_scale) {
   return make_scoped_ptr(new PictureLayerTiling(contents_scale));
 }
 
 scoped_ptr<PictureLayerTiling> PictureLayerTiling::Clone() const {
   return make_scoped_ptr(new PictureLayerTiling(*this));
 }
 
 PictureLayerTiling::PictureLayerTiling(float contents_scale)
@@ skipping 410 matching lines @@
       float distance_to_visible_in_pixels =
           TilePriority::manhattanDistance(current_screen_rect, view_rect);
 
       float time_to_visible_in_seconds =
           TilePriority::TimeForBoundsToIntersect(
               last_screen_rect, current_screen_rect, time_delta, view_rect);
       TilePriority priority(
           resolution_,
           time_to_visible_in_seconds,
           distance_to_visible_in_pixels);
+      if (store_screen_space_quads_on_tiles) {
+        bool clipped;
+        priority.set_current_screen_quad(
+            MathUtil::projectQuad(current_screen_transform,

[enne (OOO), 2013/02/12 00:21:13]

In this case, you can just set_current_screen_quad(current_screen_rect) rather
than doing a projection.

+                                  gfx::QuadF(tile_bounds),
+                                  clipped));
+      }
       tile->set_priority(tree, priority);
     }
   }
   else
   {
     for (TilingData::Iterator iter(&tiling_data_, inflated_rect);
          iter; ++iter) {
       TileMap::iterator find = tiles_.find(iter.index());
       if (find == tiles_.end())
         continue;
@@ skipping 18 matching lines @@
           TilePriority::manhattanDistance(current_screen_rect, view_rect);
 
       float time_to_visible_in_seconds =
           TilePriority::TimeForBoundsToIntersect(
               last_screen_rect, current_screen_rect, time_delta, view_rect);
 
       TilePriority priority(
           resolution_,
           time_to_visible_in_seconds,
           distance_to_visible_in_pixels);
+      if (store_screen_space_quads_on_tiles) {
+        bool clipped;
+        priority.set_current_screen_quad(
+            MathUtil::projectQuad(current_screen_transform,
+                                  gfx::QuadF(tile_bounds),

[enne (OOO), 2013/02/12 00:21:13]

Here's your low res issue: s/tile_bounds/current_layer_content_rect/.  The same
issue applies above, although you don't have to do a projection there.

+                                  clipped));
+      }
       tile->set_priority(tree, priority);
     }
   }
 
   last_source_frame_number_ = current_source_frame_number;
   last_impl_frame_time_ = current_frame_time;
 }
 
 void PictureLayerTiling::DidBecomeActive() {
   for (TileMap::const_iterator it = tiles_.begin(); it != tiles_.end(); ++it) {
     it->second->set_priority(ACTIVE_TREE, it->second->priority(PENDING_TREE));
     it->second->set_priority(PENDING_TREE, TilePriority());
 
     // Tile holds a ref onto a picture pile. If the tile never gets invalidated
     // and recreated, then that picture pile ref could exist indefinitely.  To
     // prevent this, ask the client to update the pile to its own ref.  This
     // will cause PicturePileImpls and their clones to get deleted once the
     // corresponding PictureLayerImpl and any in flight raster jobs go out of
     // scope.
     client_->UpdatePile(it->second);
   }
 }
 
 }  // namespace cc