lib/src/directive_parser.dart - Issue 12096106: work in progress: observable implementation using detailed change records

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/directive_parser.dart

Issue 12096106: work in progress: observable implementation using detailed change records (Closed) Base URL: https://github.com/dart-lang/web-ui.git@master

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/src/directive_parser.dart

diff --git a/lib/src/directive_parser.dart b/lib/src/directive_parser.dart

index c2a8a3b23fa0f8ae2a8859fbccdcd9178252a0a3..06adae3efff6ed8890cdd0c89afce75443bc41ea 100644

--- a/lib/src/directive_parser.dart

+++ b/lib/src/directive_parser.dart

@@ -24,7 +24,8 @@ DartCodeInfo parseDartCode(String code, Path file, {Messages messages}) {

}

/** A parser that extracts top-level directives. */

-// TODO(sigmund): add source-span to error messages

+// TODO(sigmund): add source-span to error messages.

+// TODO(jmesserly): replace this with something based on compiler_unsupported.

class _DirectiveParser {

/** Path to the source file containing the code (for error messages). */

Path file;

« no previous file with comments | « lib/src/dart_parser.dart ('k') | lib/src/emitters.dart » ('j') | no next file with comments »