Issue 12096103: Reland: Aura: Fix crash on dragging URL into tab strip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12096103: Reland: Aura: Fix crash on dragging URL into tab strip (Closed)

Created:
7 years, 10 months ago by James Cook

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland: Aura: Fix crash on dragging URL into tab strip The widget for the window containing the drop-location arrow needs a parent under Aura to be placed correctly. A parent or context for each widget is required due to https://codereview.chromium.org/11829040/ BUG=173229 TEST=Open two tabs, verify you can drag a blue URL link into the space between the two tabs in the tab strip. The URL should open in a new tab and Chrome should not crash. TBR=sky@chromium.org Original commit: https://src.chromium.org/viewvc/chrome?view=rev&revision=180006 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180151

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/tabs/tab_strip.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View		3 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

commit-bot: I haz the power

7 years, 10 months ago (2013-02-01 03:39:09 UTC) #1

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/12096103/1