Issue 12096101: Roll Skia DEPS to 7502

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12096101: Roll Skia DEPS to 7502 (Closed)

Created:
7 years, 10 months ago by robertphillips

Modified:
7 years, 10 months ago

Reviewers:
bsalomon, reed1

CC:
chromium-reviews, skia-dev_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll Skia DEPS to 7502 control: https://codereview.chromium.org/12087123/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180138

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/SkFontHost_fontconfig.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/skia.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robertphillips

This is a second attempt at the roll to 7502. In the first one (https://codereview.chromium.org/12091101/) ...

7 years, 10 months ago (2013-02-01 13:52:12 UTC) #1

This is a second attempt at the roll to 7502. In the first one
(https://codereview.chromium.org/12091101/) I omitted a change to
skia\ext\SkFontHost_fontconfig. This broke several linux flavored builds and
cros_daisy (but mysteriously not linux_layout*). I have rerun most of the broken
bots in this roll. The discrepancies between the rolls and control are:

cros_daisy
   roll:    1st try - compile failed in skia\ext\SkFontHost_fontconfig.cpp
            2nd try - never kicked off
   control: green

linux
   roll:    
            1st try - compile failed in skia\ext\SkFontHost_fontconfig.cpp
            2nd try - 
                browser_tests failed 5
                    TestEncodingAutoDetect
                    SimpleTest
                    MultipleRealmCancellation
                    URLNotInCache
                    HttpsMiddleClickTargetBlankOrigin
                content_browsertests failed 23
                    ChangeWindowName
                    BasicPlayback_AudioClearVideo_0
                    BasicPlayback_AudioOnly_0
                    BasicPlayback_VideoAudio_0
                    BasicPlayback_VideoClearAudio_0
                    FrameChangeVideo_0
                    BasicPlayback_AudioClearVideo_0
                    BasicPlayback_AudioOnly_0
                    BasicPlayback_VideoAudio_0
                    BasicPlayback_VideoClearAudio_0
                    FrameChangeVideo_0
                    VideoBearTheora_0
                    VideoBearWavPcm_0
                    VideoBearWavPcm192kHz_0
                    VideoBearWebm_0
                    VideoTulipWebm_0
                    VideoBearTheora_0
                    VideoBearWavPcm_0
                    VideoBearWavPcm192kHz_0
                    VideoBearWebm_0
                    VideoTulipWebm_0
                    TransactionTests
                    VideoLoopTest
   control: 
            dbus_unittests 1 disabled failed 1
                Echo_HugePayload
            browser_tests failed 2
                OptionsPage
                OptionsPage

linux_chromeos_asan
   roll:        1st try - compile failed in skia\ext\SkFontHost_fontconfig.cpp
                2nd try - never kicked off
   control: 
                content_browsertests failed 1
                    CrossSiteOnunloadCookie

mac_asan
   roll:    browser_tests - time out
   control: green

lgtm

Expand Messages | Collapse Messages