Finalizing the 'OnClick' behavior of the Launcher items.

ui/views/controls/menu/menu_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_DELEGATE_H_
 #define UI_VIEWS_CONTROLS_MENU_MENU_DELEGATE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 53 matching lines @@
   // radio buttons and check buttons.
   virtual bool IsItemChecked(int id) const;
 
   // The string shown for the menu item. This is only invoked when an item is
   // added with an empty label.
   virtual string16 GetLabel(int id) const;
 
   // The font for the menu item label.
   virtual const gfx::Font* GetLabelFont(int id) const;
 
+  // Override the background color of a given menu item dependent on the
+  // |command_id| and its |is_hovered| state. Returns true if it chooses to
+  // override the color.
+  virtual bool GetBackgroundColor(int command_id,
+                                  bool is_hovered,
+                                  SkColor* override_color) const;

[sky, 2013/01/31 21:15:02]

This shouldn't take is_hovered, instead it should only be invoked if the item
isn't selected. That means you can get rid of colors you're adding to native
theme.

[Mr4D (OOO till 08-26), 2013/01/31 22:38:52]

Actually... The background colors are different from the normal menu colors for
the hovered AND the non hovered state. So we need both separately.

[sky, 2013/02/01 00:17:33]

Ugh.
Ok, in that case the names you've gone with are inconsistant and confusing here.
is_hovered->selected
kColorId_SelectedMenuItemBackground->HightedMenuItemBackground
kColorId_FocusedSelectedMenuItemBackground->SelectedHighlightMenuItemBackground

And be sure and add a description above these in native_theme since it is not
obvious.

[Mr4D (OOO till 08-26), 2013/02/01 15:48:28]

As discussed: The names are correct. The function GetBackgroundColor called from
MenuViewItem is "universally usable" and gets the state of the mouse hover. The
implementing function (in my case the running applications list) has a very
special sate: The "Application is active" state - which does not translate into
any other menu state. However, it can also be "highlighted" via hover.

But since this is so confusing - and there is currently only one incident where
this is used, I remove the system colors and we can re-introduce them with a
better name if needed.
Done.

+
   // The tooltip shown for the menu item. This is invoked when the user
   // hovers over the item, and no tooltip text has been set for that item.
   virtual string16 GetTooltipText(int id, const gfx::Point& screen_loc) const;
 
   // If there is an accelerator for the menu item with id |id| it is set in
   // |accelerator| and true is returned.
   virtual bool GetAccelerator(int id, ui::Accelerator* accelerator);
 
   // Shows the context menu with the specified id. This is invoked when the
   // user does the appropriate gesture to show a context menu. The id
@@ skipping 128 matching lines @@
   // and |right_margin| accordingly. Note: Negative values can be returned.
   virtual void GetHorizontalIconMargins(int command_id,
                                         int icon_size,
                                         int* left_margin,
                                         int* right_margin) const;
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MENU_MENU_DELEGATE_H_