Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 12096093: Add POST_WITHOUT_BODY to the UrlFetcher's method. (Closed)

Created:
7 years, 10 months ago by hidehiko
Modified:
7 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, satorux1, kinaba, willchan no longer on Chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add POST_WITHOUT_BODY to the UrlFetcher's method. This CL adds a new method enum POST_WITHOUT_BODY. In most cases, POST request has non-empty body and non-content-type header. The current implementation has some (D)CHECKs for it. However, there are some cases that we'd like to send POST request without body (or, we may say it is empty body), content-type and content length headers. The new method POST_WITHOUT_BODY is for supporting such cases. BUG=148628 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180478

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Add comment fot the new enum value. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M net/url_request/url_fetcher.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 10 months ago (2013-02-01 01:59:23 UTC) #1
mmenke
On 2013/02/01 01:59:23, hidehiko wrote: > Thank you for your review in advance, > - ...
7 years, 10 months ago (2013-02-01 15:22:56 UTC) #2
mmenke
https://codereview.chromium.org/12096093/diff/1/net/url_request/url_fetcher.h File net/url_request/url_fetcher.h (right): https://codereview.chromium.org/12096093/diff/1/net/url_request/url_fetcher.h#newcode84 net/url_request/url_fetcher.h:84: POST_WITHOUT_BODY, Please add a comment that this includes no ...
7 years, 10 months ago (2013-02-01 15:25:18 UTC) #3
hidehiko
Thank you for your review. Could you take another look? https://codereview.chromium.org/12096093/diff/1/net/url_request/url_fetcher.h File net/url_request/url_fetcher.h (right): https://codereview.chromium.org/12096093/diff/1/net/url_request/url_fetcher.h#newcode84 ...
7 years, 10 months ago (2013-02-01 16:56:59 UTC) #4
hidehiko
Hello Matt, Could you kindly take a quick glance at the updated comment? best regards, ...
7 years, 10 months ago (2013-02-04 17:24:43 UTC) #5
mmenke
On 2013/02/04 17:24:43, hidehiko wrote: > Hello Matt, > > Could you kindly take a ...
7 years, 10 months ago (2013-02-04 17:27:18 UTC) #6
hidehiko
On 2013/02/04 17:27:18, Matt Menke wrote: > On 2013/02/04 17:24:43, hidehiko wrote: > > Hello ...
7 years, 10 months ago (2013-02-04 17:29:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12096093/22001
7 years, 10 months ago (2013-02-04 17:29:26 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-04 19:41:45 UTC) #9
Message was sent while issue was closed.
Change committed as 180478

Powered by Google App Engine
This is Rietveld 408576698