ui/views/controls/menu/menu_scroll_view_container.cc - Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_scroll_view_container.cc

Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Additional refactoring and cleanup. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_scroll_view_container.cc

diff --git a/ui/views/controls/menu/menu_scroll_view_container.cc b/ui/views/controls/menu/menu_scroll_view_container.cc

index 503e214b90961ef7cae9abf2ce926c0dfb1bb245..c3a6f0f14ec158886024b9f66637964caa649229 100644

--- a/ui/views/controls/menu/menu_scroll_view_container.cc

+++ b/ui/views/controls/menu/menu_scroll_view_container.cc

@@ -289,9 +289,8 @@ void MenuScrollViewContainer::CreateDefaultBorder() {

}

void MenuScrollViewContainer::CreateBubbleBorder() {

- bubble_border_ = new BubbleBorder(

- arrow_location_,

- BubbleBorder::NO_SHADOW);

+ bubble_border_ =

+ new BubbleBorder(arrow_location_, BubbleBorder::NO_SHADOW, SK_ColorWHITE);

set_border(bubble_border_);

set_background(new BubbleBackground(bubble_border_));

}