ui/views/bubble/bubble_border.cc - Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_border.cc

Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Additional refactoring and cleanup. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_border.cc

diff --git a/ui/views/bubble/bubble_border.cc b/ui/views/bubble/bubble_border.cc

index ae0bd89ca7847ed588ecc1e4d97f517f2a1b82a2..cbe770213efde8ab228a1ffb7f18c7dbb99f9542 100644

--- a/ui/views/bubble/bubble_border.cc

+++ b/ui/views/bubble/bubble_border.cc

@@ -133,12 +133,12 @@ struct BubbleBorder::BorderImages {

struct BubbleBorder::BorderImages*

BubbleBorder::border_images_[SHADOW_COUNT] = { NULL };

-BubbleBorder::BubbleBorder(ArrowLocation arrow_location, Shadow shadow)

+BubbleBorder::BubbleBorder(ArrowLocation arrow, Shadow shadow, SkColor color)

: override_arrow_offset_(0),

- arrow_location_(arrow_location),

+ arrow_location_(arrow),

paint_arrow_(true),

alignment_(ALIGN_ARROW_TO_MID_ANCHOR),

- background_color_(SK_ColorWHITE) {

+ background_color_(color) {

DCHECK(shadow < SHADOW_COUNT);

images_ = GetBorderImages(shadow);