chrome/browser/ui/views/notifications/balloon_view_views.cc - Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/notifications/balloon_view_views.cc

Issue 12096084: Cleanup BubbleFrameView and BubbleBorder construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Additional refactoring and cleanup. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/notifications/balloon_view_views.cc

diff --git a/chrome/browser/ui/views/notifications/balloon_view_views.cc b/chrome/browser/ui/views/notifications/balloon_view_views.cc

index 02ccd36c83898f63cf1a7d67913618c544d92862..7ff2ada54f4e076e20d0065374138914c51d7c8f 100644

--- a/chrome/browser/ui/views/notifications/balloon_view_views.cc

+++ b/chrome/browser/ui/views/notifications/balloon_view_views.cc

@@ -105,10 +105,8 @@ BalloonViewImpl::BalloonViewImpl(BalloonCollection* collection)

// We're owned by Balloon and don't want to be deleted by our parent View.

set_owned_by_client();

- views::BubbleBorder* bubble_border =

- new views::BubbleBorder(views::BubbleBorder::FLOAT,

- views::BubbleBorder::NO_SHADOW);

- set_border(bubble_border);

+ set_border(new views::BubbleBorder(views::BubbleBorder::FLOAT,

+ views::BubbleBorder::NO_SHADOW, SK_ColorWHITE));

}

BalloonViewImpl::~BalloonViewImpl() {