remoting/host/chromoting_messages.h - Issue 12096071: Adding a unit test to verify the IPC channel between the network and desktop processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/chromoting_messages.h

Issue 12096071: Adding a unit test to verify the IPC channel between the network and desktop processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/video/capture/screen/screen_capturer_fake.cc ('K') | « media/video/capture/screen/screen_capturer_fake.cc ('k') | remoting/host/daemon_process_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/chromoting_messages.h

diff --git a/remoting/host/chromoting_messages.h b/remoting/host/chromoting_messages.h

index f62bfbb588606a7d79f125a9c9993dfe255f6ac7..68d47a7e16658414d9efb0a94a74df7cbbaa2b77 100644

--- a/remoting/host/chromoting_messages.h

+++ b/remoting/host/chromoting_messages.h

@@ -40,7 +40,7 @@ IPC_MESSAGE_CONTROL1(ChromotingDaemonNetworkMsg_TerminalDisconnected,

// Notifies the network process that |terminal_id| is now attached to

// a desktop integration process. |desktop_process| is the handle of the desktop

-// process |desktop_pipe| is the client end of the desktop-to-network pipe

+// process. |desktop_pipe| is the client end of the desktop-to-network pipe

// opened.

// Windows only: |desktop_pipe| has to be duplicated from the desktop process

@@ -48,7 +48,7 @@ IPC_MESSAGE_CONTROL1(ChromotingDaemonNetworkMsg_TerminalDisconnected,

// the sender.

IPC_MESSAGE_CONTROL3(ChromotingDaemonNetworkMsg_DesktopAttached,

int /* terminal_id */,

- IPC::PlatformFileForTransit /* desktop_process */,

+ base::ProcessHandle /* desktop_process */,

IPC::PlatformFileForTransit /* desktop_pipe */)

//-----------------------------------------------------------------------------