Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2633)

Unified Diff: ash/test/test_metro_viewer_process_host.h

Issue 12096064: Automatic Win8 default browser registration for the ash unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/test/test_metro_viewer_process_host.h
diff --git a/ash/test/test_metro_viewer_process_host.h b/ash/test/test_metro_viewer_process_host.h
index 266239040070bd5f92c4ac3b572932749a0aed93..0b173fb91bae86ca1b52bc0652e0c2a10235e952 100644
--- a/ash/test/test_metro_viewer_process_host.h
+++ b/ash/test/test_metro_viewer_process_host.h
@@ -28,15 +28,15 @@ class TestMetroViewerProcessHost : public IPC::Listener,
explicit TestMetroViewerProcessHost(const std::string& ipc_channel_name);
virtual ~TestMetroViewerProcessHost();
- // Launches the Chrome viewer process and blocks until that viewer process
- // connects or until a timeout is reached. Returns true if the viewer process
- // connects before the timeout is reached.
+ // Launches the viewer process associated with the given |app_user_model_id|
+ // and blocks until that viewer process connects or until a timeout is
+ // reached. Returns true if the viewer process connects before the timeout is
+ // reached.
// TODO(robertshield): This creates a run-time dependency on chrome.exe as the
grt (UTC plus 2) 2013/02/12 15:37:43 The dependency is created in the registration rath
robertshield 2013/02/12 16:57:08 Done (moved to test_registrar.cc).
- // viewer process and, indirectly, setup.exe as the only thing that can
- // correctly register a program as the default browser on metro. Investigate
- // extracting the registration code and the metro init code and building them
- // into a standalone viewer process.
- bool LaunchImmersiveChromeAndWaitForConnection();
+ // viewer process. Investigate extracting the registration code and the metro
+ // init code and building them into a standalone viewer process.
+ bool LaunchImmersiveChromeAndWaitForConnection(
grt (UTC plus 2) 2013/02/12 15:37:43 Chrome -> Viewer?
robertshield 2013/02/12 16:57:08 Done.
+ const string16& app_user_model_id);
// IPC::Sender implementation:
virtual bool Send(IPC::Message* msg) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698