Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: ash/test/test_metro_viewer_process_host.h

Issue 12096064: Automatic Win8 default browser registration for the ash unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Dear Greg Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/test/test_metro_viewer_process_host.h
diff --git a/ash/test/test_metro_viewer_process_host.h b/ash/test/test_metro_viewer_process_host.h
index 266239040070bd5f92c4ac3b572932749a0aed93..de0969e3713ec261fe96b66bd7b815d1e89615d0 100644
--- a/ash/test/test_metro_viewer_process_host.h
+++ b/ash/test/test_metro_viewer_process_host.h
@@ -28,15 +28,11 @@ class TestMetroViewerProcessHost : public IPC::Listener,
explicit TestMetroViewerProcessHost(const std::string& ipc_channel_name);
virtual ~TestMetroViewerProcessHost();
- // Launches the Chrome viewer process and blocks until that viewer process
- // connects or until a timeout is reached. Returns true if the viewer process
- // connects before the timeout is reached.
- // TODO(robertshield): This creates a run-time dependency on chrome.exe as the
- // viewer process and, indirectly, setup.exe as the only thing that can
- // correctly register a program as the default browser on metro. Investigate
- // extracting the registration code and the metro init code and building them
- // into a standalone viewer process.
- bool LaunchImmersiveChromeAndWaitForConnection();
+ // Launches the viewer process associated with the given |app_user_model_id|
+ // and blocks until that viewer process connects or until a timeout is
+ // reached. Returns true if the viewer process connects before the timeout is
+ // reached.
+ bool LaunchViewerAndWaitForConnection(const string16& app_user_model_id);
// IPC::Sender implementation:
virtual bool Send(IPC::Message* msg) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698