Automatic Win8 default browser registration for the ash unittests.

win8/test/metro_registration_helper.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "win8/test/metro_registration_helper.h"
+
+#include "base/command_line.h"
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/logging.h"
+#include "base/path_service.h"
+#include "base/process.h"
+#include "base/process_util.h"
+#include "base/win/scoped_handle.h"
+#include "win8/test/test_registrar_constants.h"
+
+namespace {
+
+const int kRegistrationTimeoutMs = 30000;
+
+// Copied from util_constants.cc to avoid taking a dependency on installer_util.
+const wchar_t kChromeExe[] = L"chrome.exe";
+const wchar_t kRegistrar[] = L"test_registrar.exe";
+
+}
+
+namespace win8 {
+
+bool RegisterTestDefaultBrowser(const string16& app_user_model_id,
+                                const string16& viewer_process_name) {
+  FilePath dir;
+  if (!PathService::Get(base::DIR_EXE, &dir))
+    return false;
+
+  FilePath chrome_exe(dir.Append(kChromeExe));
+  FilePath registrar(dir.Append(kRegistrar));
+
+  if (!file_util::PathExists(chrome_exe) || !file_util::PathExists(registrar)) {
+    LOG(ERROR) << "Could not locate " << kChromeExe << " or " << kRegistrar;
+    return false;
+  }
+
+  // Perform the registration by invoking test_registrar.exe with the
+  // necessary flags:
+  //     test_registrar.exe /RegServer --appid=<appid> --exe-name=<name>
+  CommandLine register_command(registrar);
+  register_command.AppendArg("/RegServer");
+  register_command.AppendSwitchNative(win8::test::kTestAppUserModelId,
+                                      app_user_model_id);
+  register_command.AppendSwitchNative(win8::test::kTestExeName,

[grt (UTC plus 2), 2013/02/12 18:17:27]

i like this change.

[robertshield, 2013/02/12 18:35:34]

thank you.

+                                      viewer_process_name);
+
+  base::win::ScopedHandle register_handle;
+  if (base::LaunchProcess(register_command, base::LaunchOptions(),
+                          register_handle.Receive())) {
+    int ret = 0;
+    if (base::WaitForExitCodeWithTimeout(
+            register_handle, &ret,
+            base::TimeDelta::FromMilliseconds(kRegistrationTimeoutMs))) {

[grt (UTC plus 2), 2013/02/12 18:17:27]

how about using seconds rather than milliseconds?

[robertshield, 2013/02/12 18:35:34]

Done.

+      return ret == 0;
+    }
+  }
+
+  LOG(ERROR) << "Win8 registration using " << kRegistrar << " timed out.";

[grt (UTC plus 2), 2013/02/12 18:17:27]

consider logging register_command.GetCommandLineString() instead of kRegistrar
since it's a bit more informative. also, the timeout portion of this message is
only relevant if the launch succeeds. consider putting this in an }else{ block
on line 61 and using a different log message for the failure to launch. or just
change the "timed out." to "timed out or failed."

[robertshield, 2013/02/12 18:35:34]

Done.

+  return false;
+}
+
+}  // namespace win8