Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 12096047: mac: Delete GetCachedImageWithName(), it's no longer used. (Closed)

Created:
7 years, 10 months ago by Nico
Modified:
7 years, 10 months ago
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

mac: Delete GetCachedImageWithName(), it's no longer used. We used to load some images (mostly pdfs) from the app bundle instead of from a pak file. We now load everything* from pak files, so this is no longer necessary. *: We still load 4 pdf files from the bundle via nib files, see issue 111101. BUG=138772 TBR=avi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179484

Patch Set 1 #

Patch Set 2 : includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -192 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/cocoa/nsimage_cache_unittest.mm View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/mac/nsimage_cache.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/gfx/mac/nsimage_cache.mm View 1 chunk +0 lines, -74 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
7 years, 10 months ago (2013-01-29 21:06:52 UTC) #1
Robert Sesek
LGTM! I have been waiting for this day for a long time.
7 years, 10 months ago (2013-01-29 21:08:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12096047/1
7 years, 10 months ago (2013-01-29 21:16:25 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on ios_dbg_simulator HTTP Error 400: Bad Request
7 years, 10 months ago (2013-01-29 21:24:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12096047/7001
7 years, 10 months ago (2013-01-29 21:27:02 UTC) #5
commit-bot: I haz the power
Presubmit check for 12096047-7001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-01-29 21:27:11 UTC) #6
Nico
+avi for content/OWNERS
7 years, 10 months ago (2013-01-29 21:30:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12096047/7001
7 years, 10 months ago (2013-01-29 21:40:00 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-29 22:14:43 UTC) #9
Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698