Issue 12096027: Adds an ash global shortcut key for message center.

Issue 12096027: Adds an ash global shortcut key for message center. (Closed)

Created:
7 years, 10 months ago by Jun Mukai

Modified:
7 years, 10 months ago

Reviewers:
stevenjb, Daniel Erat

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds an ash global shortcut key for message center. BUG=172705 TEST=on device, login, and press Shift-Alt-n. Also make sure NOT toggling when login/lock-screens. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181847

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : toggle -> show #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
M	ash/accelerators/accelerator_controller.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM after alphabetization is fixed https://codereview.chromium.org/12096027/diff/1/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/12096027/diff/1/ash/accelerators/accelerator_table.cc#newcode130 ash/accelerators/accelerator_table.cc:130: TOGGLE_MESSAGE_CENTER_BUBBLE }, same here, ...

7 years, 10 months ago (2013-01-28 23:37:29 UTC) #2

Jun Mukai

https://codereview.chromium.org/12096027/diff/1/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/12096027/diff/1/ash/accelerators/accelerator_table.cc#newcode130 ash/accelerators/accelerator_table.cc:130: TOGGLE_MESSAGE_CENTER_BUBBLE }, On 2013/01/28 23:37:29, Daniel Erat wrote: > ...

7 years, 10 months ago (2013-01-28 23:40:09 UTC) #3

stevenjb

https://codereview.chromium.org/12096027/diff/1/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/12096027/diff/1/ash/accelerators/accelerator_controller.cc#newcode635 ash/accelerators/accelerator_controller.cc:635: Shell::GetPrimaryRootWindowController(); Any reason we can't put this logic in ...

7 years, 10 months ago (2013-01-28 23:46:55 UTC) #4

Jun Mukai

Updating an old code review... Due to the discussion in the bug, we have 'SHOW' ...

7 years, 10 months ago (2013-02-12 00:29:13 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12096027/6001

7 years, 10 months ago (2013-02-12 01:15:57 UTC) #7

Message was sent while issue was closed.

Change committed as 181847

Expand Messages | Collapse Messages