mojo/devtools/common/android_gdb/install_remote_file_reader.py - Issue 1209593002: GDB support for Android in devtools' debugger.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/devtools/common/android_gdb/install_remote_file_reader.py

Issue 1209593002: GDB support for Android in devtools' debugger. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import android_gdb.config as config

	6 import subprocess

	7 import tempfile

	8

	9

	10 def install_binary(gsutil, adb='adb'):
	ppi 2015/07/09 13:12:38 install_binary -> install_remote_file_reader install_binary -> install_remote_file_reader qsr 2015/07/09 13:54:18 Given the name of the python package, what about j Show quoted text On 2015/07/09 13:12:38, ppi (ooo until 8th June) wrote: > install_binary -> install_remote_file_reader Given the name of the python package, what about just install ? etiennej 2015/07/15 07:13:20 Done. Show quoted text On 2015/07/09 13:54:18, qsr wrote: > On 2015/07/09 13:12:38, ppi (ooo until 8th June) wrote: > > install_binary -> install_remote_file_reader > > Given the name of the python package, what about just install ? Done.
	11 verification_call_output = subprocess.check_output(

	12 [adb, 'shell', 'ls', config.REMOTE_FILE_READER_DEVICE_PATH])

	13 if config.REMOTE_FILE_READER_DEVICE_PATH != verification_call_output.strip():

	14 with tempfile.NamedTemporaryFile() as temp_file:

	15 subprocess.check_call([gsutil, 'cp', config.REMOTE_FILE_READER_CLOUD_PATH,

	16 temp_file.name])

	17 subprocess.check_call([adb, 'push', temp_file.name,

	18 config.REMOTE_FILE_READER_DEVICE_PATH])

	19 subprocess.check_call([adb, 'shell', 'chmod', '777',

	20 config.REMOTE_FILE_READER_DEVICE_PATH])

OLD	NEW