Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: test/ldflags-duplicates/check-ldflags.py

Issue 1209553002: Do not remote duplicate entries from ldflags when generating ninja files as it changes behavior (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Updated license headers Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ldflags-duplicates/gyptest-ldflags-duplicates.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ldflags-duplicates/check-ldflags.py
diff --git a/test/ldflags-duplicates/check-ldflags.py b/test/ldflags-duplicates/check-ldflags.py
new file mode 100755
index 0000000000000000000000000000000000000000..0515da95e434bb8e3376d83ef68fe3a50bc46c74
--- /dev/null
+++ b/test/ldflags-duplicates/check-ldflags.py
@@ -0,0 +1,25 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2015 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Verifies duplicate ldflags are not removed.
+"""
+
+import sys
+
+def CheckContainsFlags(args, substring):
+ if args.find(substring) is -1:
+ print 'ERROR: Linker arguments "%s" are missing in "%s"' % (substring, args)
+ return False;
+ return True;
+
+if __name__ == '__main__':
+ args = " ".join(sys.argv)
+ print "args = " +args
+ if not CheckContainsFlags(args, 'lib1.a -Wl,--no-whole-archive') \
+ or not CheckContainsFlags(args, 'lib2.a -Wl,--no-whole-archive'):
+ sys.exit(1);
+ sys.exit(0)
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ldflags-duplicates/gyptest-ldflags-duplicates.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698