Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1209513002: [turbofan] Make TyperCache global and thread safe. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Sven Panne, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make TyperCache global and thread safe. This way we need the common types only once per process and we don't need to recreate them for every compilation. It uses the same pattern that we already apply to caching operators. This simplifies the type cache a lot. R=svenpanne@chromium.org Committed: https://crrev.com/db4101ef81002b73f4a57ea6d115429061985acd Cr-Commit-Position: refs/heads/master@{#29251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -187 lines) Patch
M src/compiler/typer.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/typer.cc View 17 chunks +122 lines, -181 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-24 08:03:22 UTC) #1
Benedikt Meurer
Hey Sven, Jaro, Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-24 08:11:29 UTC) #3
Sven Panne
lgtm
5 years, 6 months ago (2015-06-24 08:53:02 UTC) #4
Jarin
lgtm. (although the c++11 magic frightens and confuses me)
5 years, 6 months ago (2015-06-24 09:14:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209513002/1
5 years, 6 months ago (2015-06-24 09:15:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 09:16:30 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 09:16:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db4101ef81002b73f4a57ea6d115429061985acd
Cr-Commit-Position: refs/heads/master@{#29251}

Powered by Google App Engine
This is Rietveld 408576698