Add a script to produce a syzygy-instrumented image of Chrome.dll

chrome/chrome_syzygy.gyp

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'conditions': [
     ['OS=="win" and fastbuild==0', {
-      # Reorder the initial chrome DLL executable, placing the optimized
-      # output and corresponding PDB file into the "syzygy" subdirectory.
-      # If there's a matching chrome.dll-ordering.json file present in
-      # the output directory, chrome.dll will be ordered according to that,
-      # otherwise it will be randomized.
+      # Reorder or instrument the initial chrome DLL executable, placing the
+      # optimized output and corresponding PDB file into the "syzygy"
+      # subdirectory.
       # This target won't build in fastbuild, since there are no PDBs.
       'targets': [
         {
           'target_name': 'chrome_dll_syzygy',
           'type': 'none',
           'sources' : [],
           'dependencies': [
             '<(DEPTH)/chrome/chrome.gyp:chrome_dll',
           ],
           'variables': {
             'dest_dir': '<(PRODUCT_DIR)\\syzygy',
           },
-          'actions': [
-            {
-              'action_name': 'Reorder Chrome with Syzygy',
-              'msvs_cygwin_shell': 0,
-              'inputs': [
-                '<(PRODUCT_DIR)\\chrome.dll',
-                '<(PRODUCT_DIR)\\chrome.dll.pdb',
+          'conditions': [
+            ['asan!=1', {
+              # Reorder chrome DLL executable.
+              # If there's a matching chrome.dll-ordering.json file present in
+              # the output directory, chrome.dll will be ordered according to
+              # that, otherwise it will be randomized.
+              'actions': [
+                {
+                  'action_name': 'Reorder Chrome with Syzygy',
+                  'msvs_cygwin_shell': 0,
+                  'inputs': [
+                    '<(PRODUCT_DIR)\\chrome.dll',
+                    '<(PRODUCT_DIR)\\chrome.dll.pdb',
+                  ],
+                  'outputs': [
+                    '<(dest_dir)\\chrome.dll',
+                    '<(dest_dir)\\chrome.dll.pdb',
+                  ],
+                  'action': [
+                    'python',
+                    '<(DEPTH)/chrome/tools/build/win/syzygy_reorder.py',
+                    '--input_executable', '<(PRODUCT_DIR)\\chrome.dll',
+                    '--input_symbol', '<(PRODUCT_DIR)\\chrome.dll.pdb',
+                    '--destination_dir', '<(dest_dir)',
+                  ],
+                },
               ],
-              'outputs': [
-                '<(dest_dir)\\chrome.dll',
-                '<(dest_dir)\\chrome.dll.pdb',
+            }],
+            ['asan==1', {
+              # Instrument chrome DLL executable with SyzyAsan.
+              'actions': [
+                {
+                  'action_name': 'Instrument Chrome with SyzyAsan',
+                  'msvs_cygwin_shell': 0,
+                  'inputs': [
+                    '<(PRODUCT_DIR)\\chrome.dll',
+                    '<(PRODUCT_DIR)\\chrome.dll.pdb',
+                  ],
+                  'outputs': [
+                    '<(dest_dir)\\chrome.dll',
+                    '<(dest_dir)\\chrome.dll.pdb',
+                  ],
+                  'action': [
+                    'python',
+                    '<(DEPTH)/chrome/tools/build/win/syzygy_instrument.py',

[Roger McFarlane (Chromium), 2013/02/01 18:54:30]

stray thought:

In principle you could go straight to instrument.exe here. But  having the
python script in the middle, as you've done, is probably a better choice as it
creates a customization hook for the future.

[Sébastien Marchand, 2013/02/01 19:54:31]

Yeah, the python script allows us to do more stuff than just instrumenting the
binary (i.e. Copying the agent DLL to the destination directory), and I think
it's a good way to support more mode of instrumentation in the future...

+                    '--mode', 'asan',
+                    '--agent_dll', '<(DEPTH)\\third_party\\syzygy\\binaries'
+                        '\\exe\\asan_rtl.dll',
+                    '--input_executable', '<(PRODUCT_DIR)\\chrome.dll',
+                    '--input_symbol', '<(PRODUCT_DIR)\\chrome.dll.pdb',
+                    '--destination_dir', '<(dest_dir)',
+                  ],
+                },
               ],
-              'action': [
-                'python',
-                '<(DEPTH)/chrome/tools/build/win/syzygy_reorder.py',
-                '--input_executable', '<(PRODUCT_DIR)\\chrome.dll',
-                '--input_symbol', '<(PRODUCT_DIR)\\chrome.dll.pdb',
-                '--destination_dir', '<(dest_dir)',
-              ],
-            },
+            }],
           ],
         },
       ],
     }],
   ],
 }