Media Galleries: Keep media gallery permission dialogs in sync with the gallery

chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_number_conversions.h"
 #include "chrome/browser/system_monitor/media_storage_util.h"
 #include "chrome/browser/media_gallery/media_galleries_dialog_controller_mock.h"
 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 111 matching lines @@
   old_container_height = new_container_height;
 
   dialog->UpdateGallery(&gallery2, false);
   EXPECT_EQ(2U, [dialog->checkboxes_ count]);
 
   // The checkbox container height should not have changed.
   new_container_height = NSHeight([dialog->checkbox_container_ frame]);
   EXPECT_EQ(new_container_height, old_container_height);
 }
 
+TEST_F(MediaGalleriesDialogTest, ForgetDeletes) {
+  NiceMock<MediaGalleriesDialogControllerMock> controller;
+
+  MediaGalleriesDialogController::KnownGalleryPermissions permissions;
+  EXPECT_CALL(controller, permissions()).
+      WillRepeatedly(ReturnRef(permissions));
+
+  scoped_ptr<MediaGalleriesDialogCocoa> dialog(
+      static_cast<MediaGalleriesDialogCocoa*>(
+          MediaGalleriesDialog::Create(&controller)));
+
+  EXPECT_EQ(0U, [dialog->checkboxes_ count]);
+  CGFloat old_container_height = NSHeight([dialog->checkbox_container_ frame]);
+
+  MediaGalleryPrefInfo gallery1 = MakePrefInfoForTesting(1);
+  dialog->UpdateGallery(&gallery1, true);
+  EXPECT_EQ(1U, [dialog->checkboxes_ count]);
+
+  // The checkbox container should be taller.
+  CGFloat new_container_height = NSHeight([dialog->checkbox_container_ frame]);
+  EXPECT_GT(new_container_height, old_container_height);
+  old_container_height = new_container_height;
+
+  MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2);
+  dialog->UpdateGallery(&gallery2, true);
+  EXPECT_EQ(2U, [dialog->checkboxes_ count]);
+
+  // The checkbox container should be taller.
+  new_container_height = NSHeight([dialog->checkbox_container_ frame]);

[sail, 2013/02/08 19:48:22]

this test is a bit long. How about removing the two "should be taller" test and
only do the "should be shorter" test. Something like:
dialog->UpdateGallery(&gallery1, true);
dialog->UpdateGallery(&gallery2, true);
CGFloat new_container_height = NSHeight([dialog->checkbox_container_ frame]);

dialog->ForgetGallery(&gallery2);

...

[Lei Zhang, 2013/02/08 20:48:02]

Done.

+  EXPECT_GT(new_container_height, old_container_height);
+  old_container_height = new_container_height;
+
+  dialog->ForgetGallery(&gallery2);
+  EXPECT_EQ(1U, [dialog->checkboxes_ count]);
+
+  // The checkbox container should be shorter.
+  new_container_height = NSHeight([dialog->checkbox_container_ frame]);
+  EXPECT_LT(new_container_height, old_container_height);
+}
+
 }  // namespace chrome