apps/prefs.h - Issue 12095052: Move app_launcher.* out of chrome/browser/extensions and into apps/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/prefs.h

Issue 12095052: Move app_launcher.* out of chrome/browser/extensions and into apps/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved switches back Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_APPS_PREFS_H_
	tfarina 2013/02/01 15:11:24 APPS_PREFS_H_ APPS_PREFS_H_ benwells 2013/02/08 07:18:00 Wow, yeah. Presubmit didn't catch it?!? Show quoted text On 2013/02/01 15:11:24, tfarina wrote: > APPS_PREFS_H_ Wow, yeah. Presubmit didn't catch it?!?
	6 #define CHROME_APPS_PREFS_H_

	7

	8 #include "base/basictypes.h"
	tfarina 2013/02/01 15:11:24 not needed not needed benwells 2013/02/08 07:18:00 Done. Show quoted text On 2013/02/01 15:11:24, tfarina wrote: > not needed Done.
	9

	10 class PrefServiceSimple;

	11

	12 namespace apps {

	13

	14 namespace prefs {

	15

	16 extern const char kAppLauncherIsEnabled[];
	tfarina 2013/02/01 15:11:24 can we move this to a apps/apps_constants.h or app can we move this to a apps/apps_constants.h or apps/apps_pref_names.h? I dunno. This just doesn't seem to be the place for this constant. benwells 2013/02/08 07:18:00 Done. Show quoted text On 2013/02/01 15:11:24, tfarina wrote: > can we move this to a apps/apps_constants.h or apps/apps_pref_names.h? I dunno. > This just doesn't seem to be the place for this constant. Done.
	17

	18 } // namespace prefs

	19

	20 // Register preferences for the apps system.

	21 void RegisterPrefs(PrefServiceSimple* pref_service);

	22

	23 } // namespace apps

	24

	25 #endif // CHROME_APPS_PREFS_H_

OLD	NEW