apps/DEPS - Issue 12095052: Move app_launcher.* out of chrome/browser/extensions and into apps/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/DEPS

Issue 12095052: Move app_launcher.* out of chrome/browser/extensions and into apps/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved switches back Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base",	2 "+base",

3 "+content",	3 "+content",
	tfarina 2013/02/01 15:32:37 content/ should not be allowed to depend on apps/ content/ should not be allowed to depend on apps/ otherwise it will create a circular dependency :) benwells 2013/02/08 07:18:00 Content should not, and cannot depend on apps. Thi Show quoted text On 2013/02/01 15:32:37, tfarina wrote: > content/ should not be allowed to depend on apps/ otherwise it will create a > circular dependency :) Content should not, and cannot depend on apps. This doesn't need an explicit rule in content DEPS.
4 # Temporary allowed includes.	4 # Temporary allowed includes.

5 # TODO(benwells): remove these.	5 # TODO(benwells): remove these.
	tfarina 2013/02/01 15:32:37 can you put the crbug.com/ link that is tracking t can you put the crbug.com/ link that is tracking this work here? benwells 2013/02/08 07:18:00 Done. Show quoted text On 2013/02/01 15:32:37, tfarina wrote: > can you put the crbug.com/ link that is tracking this work here? Done.
	6 "+chrome/browser/browser_process.h",

6 "+chrome/browser/extensions",	7 "+chrome/browser/extensions",

	8 "+chrome/browser/prefs/pref_service.h",

7 "+chrome/browser/profiles",	9 "+chrome/browser/profiles",

8 "+chrome/common/chrome_notification_types.h",	10 "+chrome/common/chrome_notification_types.h",

	11 "+chrome/common/chrome_switches.h",

9 "+chrome/common/extensions",	12 "+chrome/common/extensions",

	13 "+chrome/installer",
	tfarina 2013/02/01 15:32:37 are there plans to move installer somewhere else? are there plans to move installer somewhere else? I doubt this will be fixed in the short term :/ benwells 2013/02/08 07:18:00 I don't think there is a plan, but there should be Show quoted text On 2013/02/01 15:32:37, tfarina wrote: > are there plans to move installer somewhere else? I doubt this will be fixed in > the short term :/ I don't think there is a plan, but there should be. The TODO above is a long term todo :)
10 ]	14 ]

OLD	NEW

« no previous file with comments | « no previous file | apps/app_launcher.h » ('j') | apps/app_launcher.cc » ('J')