Issue 12095045: Merge 175642 (also includes 175980)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12095045: Merge 175642 (also includes 175980) (Closed)

Created:
7 years, 10 months ago by Chris Evans

Modified:
7 years, 10 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1364/src/

Visibility:
Public.

Merge 175642 (also includes 175980) > Don't allow path traversal paths on the base file helpers > > This forces explicit normalization of paths and make path escaping security bugs much harder to exploit. See for example bug 167122 > > BUG=168890 > TEST=included tests > Review URL: https://codereview.chromium.org/11782005 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179458

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -30 lines)			Patch
M	base/file_util.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/file_util.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/platform_file.h	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	base/platform_file.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	base/platform_file_posix.cc	View	3 chunks	+17 lines, -15 lines	0 comments	Download
M	base/platform_file_win.cc	View	2 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/test/base/v8_unit_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)