Allow platform apps to add themselves to the Action Box.

chrome/browser/ui/toolbar/action_box_button_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_ACTION_BOX_BUTTON_CONTROLLER_H_
 #define CHROME_BROWSER_UI_TOOLBAR_ACTION_BOX_BUTTON_CONTROLLER_H_
 
 #include <map>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
-#include "chrome/browser/ui/toolbar/action_box_menu_model.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/base/models/simple_menu_model.h"
 
+class ActionBoxMenuModel;
 class Browser;
 
 namespace extensions {
 class Extension;
 }
 
 namespace ui {
 class MenuModel;
 }
 
 // Controller for the action box.
 //
 // This should have the same lifetime as the action box itself -- that is, more
 // or less the lifetime of the tab -- unlike ActionBoxMenuModel which is scoped
 // to the menu being open.
 class ActionBoxButtonController : public ui::SimpleMenuModel::Delegate,
                                   public content::NotificationObserver {
  public:
   class Delegate {
    public:
     // Shows the menu with the given |menu_model|.
-    virtual void ShowMenu(scoped_ptr<ActionBoxMenuModel> menu_model) {}
+    virtual void ShowMenu(scoped_ptr<ActionBoxMenuModel> menu_model);

[not at google - send to devlin, 2013/02/01 16:39:47]

is there a c++-y reason for this change? AFAIK it's a pretty common idiom to
implement blank virtual methods inline like this.

[Rune Fevang, 2013/02/01 22:12:54]

It allows ActionBoxMenuModel to be forward declared.

 
    protected:
     virtual ~Delegate() {}
   };
 
   ActionBoxButtonController(Browser* browser, Delegate* delegate);
   virtual ~ActionBoxButtonController();
 
   // Notifies this that the action box button has been clicked.
   // Methods on the Delegate may be called re-entrantly.
   void OnButtonClicked();
 
   // Overridden from ui::SimpleMenuModel::Delegate:
   virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
   virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
   virtual bool GetAcceleratorForCommandId(
       int command_id,
       ui::Accelerator* accelerator) OVERRIDE;
   virtual void ExecuteCommand(int command_id) OVERRIDE;
 
  private:
   // Gets the command ID for an extension, creating a new one if necessary.
   int GetCommandIdForExtension(const extensions::Extension& extension);
 
-  // Gets the extension for a command ID, or NULL if there isn't one.
-  const extensions::Extension* GetExtensionForCommandId(int command_id);
+  // Returns the next command ID to be used.
+  int GetNextCommandId();
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
-  // Handles "share with X" commands.
-  void TriggerExplicitShareIntent(const GURL& share_service_url);
-
-  // Handles the "Find places to share" command. Navigates the browser to the
-  // web store to find extensions with share intents.
-  void NavigateToWebStoreShareIntentsList();
-
   Browser* browser_;
 
   Delegate* delegate_;
 
-  // The share service strings that have commands associated with them.
-  typedef std::map<int, GURL> ShareIntentServiceCommandMap;
-  ShareIntentServiceCommandMap share_intent_service_ids_;
+  typedef std::map<int, std::string> ExtensionIdCommandMap;
+  ExtensionIdCommandMap extension_command_ids_;
 
-  // The command ID to assign to the next extension that needs one.
-  int next_extension_command_id_;
-
-  // The extension IDs that have commands associated with them.
-  typedef std::map<std::string, int> ExtensionIdCommandMap;
-  ExtensionIdCommandMap extension_command_ids_;
+  // The command ID to assign to the next dynamic entry that needs one.
+  int next_command_id_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ActionBoxButtonController);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_ACTION_BOX_BUTTON_CONTROLLER_H_