IO v2: Update a number of HTTP tests to pass

IO v2: Update a number of HTTP tests to pass

R=ajohnsen@google.com
Committed: https://code.google.com/p/dart/source/detail?r=17748

[Søren Gjesse, 2013-01-29 08:18:23]

Adding Mads as reviewer as Anders is OOO today.

[Anders Johnsen, 2013-01-29 08:25:41]

LGTM, very sick to get these working again! :)

https://codereview.chromium.org/12095014/diff/2001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (left):

https://codereview.chromium.org/12095014/diff/2001/sdk/lib/io/http.dart#oldco...
sdk/lib/io/http.dart:834: /**
Thank you! :)

https://codereview.chromium.org/12095014/diff/2001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12095014/diff/2001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:1426: factory _HttpConnectionInfo(Socket socket) {
Nit: As 'null' is a valid result, I think this should be a static method, not a
factory.

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_a...
File tests/standalone/io/http_advanced_test.dart (right):

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_a...
tests/standalone/io/http_advanced_test.dart:14: class IsolatedHttpServer {
Nice renames, makes it a lot easier to read! :)

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_r...
File tests/standalone/io/http_read_test.dart (left):

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_r...
tests/standalone/io/http_read_test.dart:212: void testReadShort(bool
chunkedEncoding) {
Why is this one removed?

[Søren Gjesse, 2013-01-29 08:38:18]

https://codereview.chromium.org/12095014/diff/2001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12095014/diff/2001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:1426: factory _HttpConnectionInfo(Socket socket) {
On 2013/01/29 08:25:41, Anders Johnsen wrote:
> Nit: As 'null' is a valid result, I think this should be a static method, not
a
> factory.

Done.

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_r...
File tests/standalone/io/http_read_test.dart (left):

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_r...
tests/standalone/io/http_read_test.dart:212: void testReadShort(bool
chunkedEncoding) {
On 2013/01/29 08:25:41, Anders Johnsen wrote:
> Why is this one removed?

It was testing "short reads", where InputStream.read was called with a small
number. With the stream we cannot do that.

Also the test above was testing InputStream.readInto, which we also don't have
anymore, so it is just processing the data it is given from the stream.

[Anders Johnsen, 2013-01-29 08:40:26]

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_r...
File tests/standalone/io/http_read_test.dart (left):

https://codereview.chromium.org/12095014/diff/2001/tests/standalone/io/http_r...
tests/standalone/io/http_read_test.dart:212: void testReadShort(bool
chunkedEncoding) {
On 2013/01/29 08:38:18, Søren Gjesse wrote:
> On 2013/01/29 08:25:41, Anders Johnsen wrote:
> > Why is this one removed?
> 
> It was testing "short reads", where InputStream.read was called with a small
> number. With the stream we cannot do that.
> 
> Also the test above was testing InputStream.readInto, which we also don't have
> anymore, so it is just processing the data it is given from the stream.

Ahh, I see. I was thinking about the small reads VM flag. Sounds good to just
remove the test! :)