Properly register types on the JS foreign instruction.

sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBailoutTarget(HBailoutTarget node);
   R visitBitAnd(HBitAnd node);
@@ skipping 1525 matching lines @@
 
   accept(HVisitor visitor) => visitor.visitLocalSet(this);
 
   HLocalValue get local => inputs[0];
   HInstruction get value => inputs[1];
   bool isJsStatement() => true;
 }
 
 class HForeign extends HInstruction {
   final DartString code;
   final HType foreignType;

[kasperl, 2013/02/04 09:27:50]

Could this be type instead of foreignType? The foreign part is sort of implied
by the fact that the field is on a foreign instruction.

[ngeoffray, 2013/02/04 10:45:06]

Done.

   final bool isStatement;
 
   HForeign(this.code,
-           DartString declaredType,
+           this.foreignType,
            List<HInstruction> inputs,
            {this.isStatement: false})
-      : foreignType = computeTypeFromDeclaredType(declaredType),
-        super(inputs) {
+        : super(inputs) {

[kasperl, 2013/02/04 09:27:50]

Too much indentation.

[ngeoffray, 2013/02/04 10:45:06]

Done.

     setAllSideEffects();
     setDependsOnSomething();
   }
 
   HForeign.statement(code, List<HInstruction> inputs)
-      : this(code, const LiteralDartString('var'), inputs, isStatement: true);
+      : this(code, HType.UNKNOWN, inputs, isStatement: true);
 
   accept(HVisitor visitor) => visitor.visitForeign(this);
 
-  static HType computeTypeFromDeclaredType(DartString declaredType) {
-    if (declaredType.slowToString() == 'bool') return HType.BOOLEAN;
-    if (declaredType.slowToString() == 'int') return HType.INTEGER;
-    if (declaredType.slowToString() == 'double') return HType.DOUBLE;
-    if (declaredType.slowToString() == 'num') return HType.NUMBER;
-    if (declaredType.slowToString() == 'String') return HType.STRING;
-    if (declaredType.slowToString() == '=List') return HType.READABLE_ARRAY;
-    return HType.UNKNOWN;
-  }
-
   HType get guaranteedType => foreignType;
 
   bool isJsStatement() => isStatement;
   bool canThrow() => true;
-
 }
 
 class HForeignNew extends HForeign {
   ClassElement element;
-  HForeignNew(this.element, List<HInstruction> inputs)
-      : super(const LiteralDartString("new"),
-              const LiteralDartString("Object"), inputs);
+  HForeignNew(this.element, HType type, List<HInstruction> inputs)
+      : super(const LiteralDartString("new"), type, inputs);
   accept(HVisitor visitor) => visitor.visitForeignNew(this);
 }
 
 abstract class HInvokeBinary extends HInstruction {
   HInvokeBinary(HInstruction left, HInstruction right)
       : super(<HInstruction>[left, right]) {
     clearAllSideEffects();
     setUseGvn();
   }
 
@@ skipping 1100 matching lines @@
   HBasicBlock get start => expression.start;
   HBasicBlock get end {
     // We don't create a switch block if there are no cases.
     assert(!statements.isEmpty);
     return statements.last.end;
   }
 
   bool accept(HStatementInformationVisitor visitor) =>
       visitor.visitSwitchInfo(this);
 }