Properly register types on the JS foreign instruction.

sdk/lib/_internal/compiler/implementation/native_handler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library native;
 
 import 'dart:collection' show Queue;
 import 'dart:uri';
 import 'dart2jslib.dart' hide SourceString;
 import 'elements/elements.dart';
@@ skipping 521 matching lines @@
     if (specLiteral != null) {
       String specString = specLiteral.dartString.slowToString();
       // Various things that are not in fact types.
       if (specString == 'void') return NativeBehavior.NONE;
       if (specString == '' || specString == 'var') {
         var behavior = new NativeBehavior();
         behavior.typesReturned.add(compiler.objectClass.computeType(compiler));
         return behavior;
       }
       var behavior = new NativeBehavior();
+      LinkBuilder<Element> types = new LinkBuilder<Element>();

[ahe, 2013/01/28 15:14:31]

This looks like a list of "elements", not "types".

       for (final typeString in specString.split('|')) {
         var type = _parseType(typeString, compiler,
             (name) => resolver.resolveTypeFromString(name),
             jsCall);
         behavior.typesInstantiated.add(type);
         behavior.typesReturned.add(type);
+        if (type == SpecialType.JsObject) {
+          types.addLast(compiler.objectClass);
+        } else if (type == SpecialType.JsArray) {
+          types.addLast(compiler.backend.listImplementation);
+        } else {
+          types.addLast(type.element);
+        }
       }
+      compiler.typesTask.typedNodes[jsCall] = types.toLink();

[ahe, 2013/01/28 15:14:31]

Please abstract this operation.

[sra1, 2013/01/28 20:12:20]

Move the assignment out to the call site of ofJsCall or to the ssa builder.

NativeBehavior is just data about the operation.
I'd like to keep the NativeBehavior methods idempotent.
We will add data for use by effect analysis, global type inference, range
analysis etc to NativeBehavior.
Adding updates to other compiler phases here will rapidly get ugly as more
phases become clients of the information. 

Calling NativeBehavior.ofJsCall should not have any side-effects.
For example, the ssa builder should be able to call NativeBehavior.ofXXX rather
than rely on some other phase caching the derived information.
It will rapidly get ugly when we also need the types for global type analysis,
and the effects (when we add those.).

It would be OK to cache the NativeBehavior.

Converting from NativeBehavior to HType should be a separate operation and made
to work on NativeBehavior.NONE (returned in another branch.)
Then the same code can be used at calls to native methods to get the returned
type, which will help with the DOM benchmarks.

       return behavior;
     }
 
     // TODO(sra): We could accept a type identifier? e.g. JS(bool, '1<2').  It
     // is not very satisfactory because it does not work for void, dynamic.
 
     compiler.cancel("Unexpected JS first argument", node: firstArg);
   }
 
   static NativeBehavior ofMethod(FunctionElement method, Compiler compiler) {
@@ skipping 314 matching lines @@
     } else if (element.kind == ElementKind.GETTER) {
       nativeMethodCall = '$receiver$nativeMethodName';
     } else if (element.kind == ElementKind.SETTER) {
       nativeMethodCall = '$receiver$nativeMethodName = $foreignParameters';
     } else {
       builder.compiler.internalError('unexpected kind: "${element.kind}"',
                                      element: element);
     }
 
     DartString jsCode = new DartString.literal(nativeMethodCall);
-    builder.push(
-        new HForeign(jsCode, const LiteralDartString('Object'), inputs));
+    builder.push(new HForeign(jsCode, HType.UNKNOWN, inputs));
     builder.close(new HReturn(builder.pop())).addSuccessor(builder.graph.exit);
   } else {
     if (parameters.parameterCount != 0) {
       compiler.cancel(
           'native "..." syntax is restricted to functions with zero parameters',
           node: nativeBody);
     }
     LiteralString jsCode = nativeBody.asLiteralString();
     builder.push(new HForeign.statement(jsCode.dartString, <HInstruction>[]));
   }
 }